Hi， JB，
Would you please take a look at this？
Thanks
On 2019/12/19 07:23:05, Gosling Von mailto:f...@gmail.com>>
wrote:
> Hi,>
>
> +1 (binding)>
>
> I checked:>
> - incubating in name>
> - signatures and hashes good>
> - DISCLAIMER exists>
> - LICENSE is fine>
> - NOTICE is fine comparing to th
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360760579
##
File path: src/butil/string_printf.h
##
@@ -45,6 +46,27 @@ int string_appendf(std::string* output, const char* format,
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761754
##
File path: src/brpc/redis_command.cpp
##
@@ -18,45 +18,30 @@
// Authors: Ge,Jun (ge...@baidu.com)
#include "butil/lo
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360763133
##
File path: src/brpc/redis_reply.h
##
@@ -94,6 +122,9 @@ class RedisReply {
// Returns PARSE_ERROR_ABSOLUTELY_WRONG
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761555
##
File path: src/brpc/redis_reply.cpp
##
@@ -37,12 +39,65 @@ const char* RedisReplyTypeToString(RedisReplyType type) {
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360760870
##
File path: src/brpc/redis_reply.h
##
@@ -200,11 +286,16 @@ inline const char* RedisReply::error_message() const {
}
jamesge commented on a change in pull request #972: Redis server protocol
URL: https://github.com/apache/incubator-brpc/pull/972#discussion_r360761223
##
File path: src/brpc/redis_reply.h
##
@@ -56,6 +59,29 @@ class RedisReply {
bool is_string() const; // True if the
