tanzhongyibidu opened a new issue #1013: the issue list in justin's email that
block release
URL: https://github.com/apache/incubator-brpc/issues/1013
I’m -1 (binding) for three reasons:
- the artefact names must include "incubating “ but this can be easily fixed
and the voting doesn’t
This is an automated email from the ASF dual-hosted git repository.
vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 7cd131f docs(license): add
This is an automated email from the ASF dual-hosted git repository.
vongosling pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new a1930cc docs(notice):update
After a quick discussion with james,
This vote is canceled.
We will work to fix these issues one by one.
BTW: Justin, add a progress disclaimer and make a release,
Does it still need go through two stage of vote process?
If So, is it an apache release but with some known issue?
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
commit aba2676d4be6bb713c1977ae1855ba55d2b26b1b
Author: jamesge
AuthorDate: Fri Jan 3 13:02:37 2020 +0800
remove
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
commit db210177b16f05ca2b2e424af9259e59b597bbad
Author: jamesge
AuthorDate: Fri Jan 3 12:59:03 2020 +0800
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from 86ca8af removed butil/md5.cc butil/md5.h test/md5_unittest.cc which
is replaceable by openssl/md5.h
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from bb29ab6 remove butil/memory/scoped_array.h which is replaceable by
unique_ptr
add 86ca8af removed
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from 907eebe Merge pull request #1012 from eric-buaa-cn/fix_pid_overwrite
add bb29ab6 remove
This is an automated email from the ASF dual-hosted git repository.
jamesge pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 4d5d8e2 bugfix: pid file may be
jamesge commented on issue #1012: bugfix: pid file may be overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012#issuecomment-570446316
Thanks for your fix , and I've checked other usages of `open`, which seem
to be OK.
jamesge merged pull request #1012: bugfix: pid file may be overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012
This is an automated message from the Apache Git Service.
To respond to the message, please log
jamesge commented on a change in pull request #537: customise span exporter
URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695272
##
File path: src/brpc/span.cpp
##
@@ -199,47 +199,42 @@ void Span::destroy() {
Span* p = _next_client;
while
jamesge commented on a change in pull request #537: customise span exporter
URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695096
##
File path: src/brpc/span.cpp
##
@@ -199,47 +199,42 @@ void Span::destroy() {
Span* p = _next_client;
while
jamesge commented on a change in pull request #537: customise span exporter
URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695570
##
File path: src/brpc/span.cpp
##
@@ -304,499 +298,44 @@ void AnnotateSpan(const char* fmt, ...) {
va_end(ap);
}
jamesge commented on a change in pull request #537: customise span exporter
URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695221
##
File path: src/brpc/span.cpp
##
@@ -199,47 +199,42 @@ void Span::destroy() {
Span* p = _next_client;
while
jamesge commented on a change in pull request #537: customise span exporter
URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362696392
##
File path: src/brpc/span.cpp
##
@@ -422,378 +314,12 @@ void Span::Submit(Span* span, int64_t cpuwide_time_us) {
eric-buaa-cn opened a new pull request #1012: bugfix: pid file may be
overwritten
URL: https://github.com/apache/incubator-brpc/pull/1012
The following step will mess up the pid file:
1. Start the server with pid file enabled. Suppose the pid is 12345.
2. Make the server core dump.
dj-alpha opened a new pull request #1011: add name for pthread worker
URL: https://github.com/apache/incubator-brpc/pull/1011
This is an automated message from the Apache Git Service.
To respond to the message, please log on
yanglimingcn commented on issue #1006: auto concurrency limiter
URL: https://github.com/apache/incubator-brpc/issues/1006#issuecomment-570181153
再请教个问题，是不是服务的请求执行时间不是很稳定的服务不太适合这个算法啊？的确根据little‘s
law的理论，得到并发度，但是我测试发现，相比最小latency，我放宽一些latency，qps就高起来了。
feifeiiong opened a new issue #1010: 异步情况下的span传递问题
URL: https://github.com/apache/incubator-brpc/issues/1010
**Describe the bug (描述bug)**
关于异步情况下 clientSpan的cr时间问题,对应span中的字段为：_received_real_us
观察到这个字段是在收包阶段设置。若brpc作为proxy，接收上游请求，之后发起异步调用，这时Server
21 matches
Mail list logo
