Re: Vote to accept caidaojin as committer

I just check the mail thread, I need to make it clear to close this vote. Together with my vote, The vote is closed as pass, we got 4 +1(binding) from below and no -1 JB Zhu jiashun James ge Tan Zhongyi Cheers. 在 2019/12/24 下午1:43，“tan zhongyi” 写入: Hi, all, Let us

[GitHub] [incubator-brpc] gromovadarya90 opened a new issue #1052: WANT TO SEE HOT PICS WITH ME? 💋 💋 💋

gromovadarya90 opened a new issue #1052: WANT TO SEE HOT PICS WITH ME? 💋 💋 💋 URL: https://github.com/apache/incubator-brpc/issues/1052 WANT TO SEE HOT PICS WITH ME? 💋 💋 💋 👇 👇 👇 https://is.gd/ms4xm3 This is an automat

[GitHub] [incubator-brpc] pklim101 opened a new issue #1051: GET请求丢失uri部分

pklim101 opened a new issue #1051: GET请求丢失uri部分 URL: https://github.com/apache/incubator-brpc/issues/1051 在ParallelChannel里，发送HTTP请求的时候，抓包发现uri并没有发送过去。 代码如下： brpc::Controller cntl; cntl.http_request().uri() = "www.test.com/abc?a=1" cntl.http_request().set_content_type("text/plain

[GitHub] [incubator-brpc] fireboyvt closed issue #1049: sigabort while brpc::Controller::SetFailed in brpc::Controller::OnVersionedRPCReturned

fireboyvt closed issue #1049: sigabort while brpc::Controller::SetFailed in brpc::Controller::OnVersionedRPCReturned URL: https://github.com/apache/incubator-brpc/issues/1049 This is an automated message from the Apache Git

[GitHub] [incubator-brpc] fireboyvt commented on issue #1049: sigabort while brpc::Controller::SetFailed in brpc::Controller::OnVersionedRPCReturned

fireboyvt commented on issue #1049: sigabort while brpc::Controller::SetFailed in brpc::Controller::OnVersionedRPCReturned URL: https://github.com/apache/incubator-brpc/issues/1049#issuecomment-591947532 异步请求在相应没返回之前就调用cntl->Failed()导致的，文档中说这种行为未定义 -

[GitHub] [incubator-brpc] zyearn commented on issue #1045: The issues need to be resolved before next release

zyearn commented on issue #1045: The issues need to be resolved before next release URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591917871 It's a good advice. We can mention in the doc that only users who need frame graph feature should download and install it. Ot

[GitHub] [incubator-brpc] tanzhongyibidu commented on issue #1045: The issues need to be resolved before next release

tanzhongyibidu commented on issue #1045: The issues need to be resolved before next release URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591893524 IMO that's a good suggestion, jiashun, how do you think? ---

[GitHub] [incubator-brpc] promoon closed issue #832: 使用prometheus采集bvar时进程core

promoon closed issue #832: 使用prometheus采集bvar时进程core URL: https://github.com/apache/incubator-brpc/issues/832 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [incubator-brpc] zyearn commented on issue #1047: brpc 是否没法保证一个连接上的请求顺序处理？有参数可以控制吗？

zyearn commented on issue #1047: brpc 是否没法保证一个连接上的请求顺序处理？有参数可以控制吗？ URL: https://github.com/apache/incubator-brpc/issues/1047#issuecomment-591865180 > > > > 如果必须诶个处理，不能有并发的话，可以在ComandHandler执行你的异步调用后调一个some_event.wait(),然后在DoneClosure里调some_event.signal()来做一个同步 > > > > > > > > > 这

[GitHub] [incubator-brpc] WillemJiang commented on issue #1045: The issues need to be resolved before next release

WillemJiang commented on issue #1045: The issues need to be resolved before next release URL: https://github.com/apache/incubator-brpc/issues/1045#issuecomment-591856739 If we don't change the frame graph code , we don't need to ship the code in the source release. We can provide a scr