liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r432825252
##
File path: example/redis_c++/redis_server.cpp
##
@@ -64,9 +64,13 @@ class GetCommandHandler : public brpc::RedisCommandHandler {
explicit Ge
liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r432825281
##
File path: src/brpc/redis_command.cpp
##
@@ -389,7 +389,7 @@ ParseError RedisCommandParser::Consume(butil::IOBuf& buf,
LOG(ERROR) << '`'
liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r432825430
##
File path: test/brpc_redis_unittest.cpp
##
@@ -565,15 +565,15 @@ std::string GetCompleteCommand(const std::vector& commands) {
TEST_F(RedisTest,
liumh8 commented on a change in pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128#discussion_r432825408
##
File path: test/brpc_redis_unittest.cpp
##
@@ -128,7 +128,7 @@ void AssertReplyEqual(const brpc::RedisReply& reply1,
// fall through
liumh8 closed pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
liumh8 closed pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
liumh8 closed pull request #1128:
URL: https://github.com/apache/incubator-brpc/pull/1128
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
