v1siuol commented on a change in pull request #1505:
URL: https://github.com/apache/incubator-brpc/pull/1505#discussion_r684542058
##
File path: src/brpc/rtmp.cpp
##
@@ -177,6 +185,8 @@ FlvReader::FlvReader(butil::IOBuf* buf)
: _read_header(false), _buf(buf) {
}
+static
zyearn merged pull request #1504:
URL: https://github.com/apache/incubator-brpc/pull/1504
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
This is an automated email from the ASF dual-hosted git repository.
jiashunzhu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from b8af1f1 Merge pull request #1506 from
guodongxiaren/printable_uri_check
new 103d78a emplace/empla
zyearn commented on pull request #1504:
URL: https://github.com/apache/incubator-brpc/pull/1504#issuecomment-894508814
> 他那段应该说的是插入已存在对象的时候，已经具名的对象。emplace是否总是优于insert是理论上的，实践上不一定。
>
>
但是前文提到如果是针对需要插入并构造新对象的时候，emplace是比insert高效的，因为emplace是传入的构造参数列表，它原地构造对象。而insert是构造临时对象，最后再move过去，然后
zyearn commented on a change in pull request #1505:
URL: https://github.com/apache/incubator-brpc/pull/1505#discussion_r684490642
##
File path: src/brpc/rtmp.cpp
##
@@ -177,6 +185,8 @@ FlvReader::FlvReader(butil::IOBuf* buf)
: _read_header(false), _buf(buf) {
}
+static
This is an automated email from the ASF dual-hosted git repository.
jiashunzhu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from 7716813 Merge pull request #1509 from apache/czy_dev
new c11d055 check is printable character in u
zyearn merged pull request #1506:
URL: https://github.com/apache/incubator-brpc/pull/1506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
zyearn commented on pull request #1506:
URL: https://github.com/apache/incubator-brpc/pull/1506#issuecomment-894502463
好的，感谢贡献 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
guodongxiaren edited a comment on pull request #1506:
URL: https://github.com/apache/incubator-brpc/pull/1506#issuecomment-894231387
@zyearn 改好了，辛苦review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
qqsun8819 commented on issue #1454:
URL: https://github.com/apache/incubator-brpc/issues/1454#issuecomment-894332280
> 一直在用proto3，没出任何问题……
不是pb3有问题，而是brpc链入tf有问题。我没有说过pb3有问题
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
wasphin commented on issue #1475:
URL: https://github.com/apache/incubator-brpc/issues/1475#issuecomment-894309492
> > > > > > > 给option的has_builtin_services设置成false就可以关闭，默认是true。
> > > >
> > > >
> > > > > > > 你可以根据你的系统环境（开发环境、测试环境、生产环境）来指定启用或关闭内置服务。
> > > >
> > > >
> >
guodongxiaren commented on pull request #1506:
URL: https://github.com/apache/incubator-brpc/pull/1506#issuecomment-894231387
@zyearnz又改了，ci也过了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
guodongxiaren closed pull request #1506:
URL: https://github.com/apache/incubator-brpc/pull/1506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: d
13 matches
Mail list logo
