guodongxiaren commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907718904
@zyearn 再看下
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
Hi all,
The vote to release Apache brpc (Incubating) 1.0.0-rc02 has passed.
We got 5 binding votes from
Zhongyi Tan
Daojin Cai
Jiashun Zhu
Juan Pan
Gaidong Mou
Vote thread:
https://lists.apache.org/thread.html/rcdf94f507621ac72226b848e3c2ff7c1e1509e37f4926011398a7a2b%40%3Cdev.brpc.ap
OK, thanks all of you.
Vote closed, we got 5 binding +1 from
Tan Zhongyi
Cai Daojin
Zhu Jiashun
Pan Juan
Mou Gaidong
Vote passed，
I will call for vote in incubator mail list.
Thanks.
Jerry Tan 于2021年8月27日周五 下午10:33写道：
> hi， lorin
> you can close this vote as passed，
> and continue to vote in
lorinlee commented on a change in pull request #1499:
URL: https://github.com/apache/incubator-brpc/pull/1499#discussion_r697942250
##
File path: docs/cn/bvar_c++.md
##
@@ -148,7 +148,7 @@ int expose_as(const butil::StringPiece& prefix, const
butil::StringPiece& name);
```
全
lorinlee commented on issue #1541:
URL: https://github.com/apache/incubator-brpc/issues/1541#issuecomment-907715418
目前不支持，请问是什么场景需要呢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lorinlee merged pull request #1542:
URL: https://github.com/apache/incubator-brpc/pull/1542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
This is an automated email from the ASF dual-hosted git repository.
lorinlee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
The following commit(s) were added to refs/heads/master by this push:
new 56ef9da Add github id of oncaller
zyearn commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907675660
> @zyearn 哦，那个if 我忘了合并，明天我改完，你再merge吧。
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guodongxiaren edited a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907659557
@zyearn 哦，那个if 我忘了合并，明天我改完，你再merge吧。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guodongxiaren edited a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907659557
@zyearn 哦，那个if 我忘了合并，明天我再改下，再merge吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guodongxiaren edited a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907659557
@zyearn 哦，那两个if 我忘了合并，明天我再改下，再merge吧
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
guodongxiaren commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907659557
@zyearn 再看看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
zyearn commented on a change in pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r697889292
##
File path: src/brpc/channel.cpp
##
@@ -295,6 +295,7 @@ int Channel::InitSingle(const butil::EndPoint&
server_addr_and_port,
zyearn commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907648462
> 因为我这个逻辑走到这里，uri.port()还是 -1 不会被
追加到Host字段中（Host只有域名）。当然Host字段中的port在Http协议中也不是必须的，不过我PR里之前修改的文档描述中写了，对方收到的Host会包含端口。所以我这里和我的文档做一下对齐。
Hi，这个改动打破backward
compatibili
guodongxiaren commented on a change in pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r697883824
##
File path: src/brpc/channel.cpp
##
@@ -332,6 +333,7 @@ int Channel::Init(const char* ns_url,
NULL, &_options.mutable
wasphin commented on a change in pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r697882663
##
File path: src/brpc/channel.cpp
##
@@ -332,6 +333,7 @@ int Channel::Init(const char* ns_url,
NULL, &_options.mutable_ssl_o
guodongxiaren commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907637593
@zyearn 改成_service_name了，也取消了协议的判断。另外给 src/brpc/details/http_message.cpp
中从uri.host()给Header补Host字段的逻辑，加上了补port。
因为我这个逻辑走到这里，uri.port()还是 -1 不会被
追加到Host字段中（H
zyearn commented on pull request #1539:
URL: https://github.com/apache/incubator-brpc/pull/1539#issuecomment-907626621
https://github.com/apache/incubator-brpc/pull/1542
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
zyearn edited a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907625668
> @zyearn 已经根据反馈修改了代码。有几个地方和你确认一下。
>
> 1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
zyearn commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907625668
> @zyearn 已经根据反馈修改了代码。有几个地方和你确认一下。
>
> 1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
> 2. 当
zyearn removed a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907623327
> @zyearn 已经根据反馈修改了代码。有几个地方和你确认一下。
>
> 1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
zyearn commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907623327
> @zyearn 已经根据反馈修改了代码。有几个地方和你确认一下。
>
> 1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
> 2. 当
zyearn merged pull request #1539:
URL: https://github.com/apache/incubator-brpc/pull/1539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsu
This is an automated email from the ASF dual-hosted git repository.
jiashunzhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git
commit 2828a4d8d744088fe3834f1c46fe1c832e5875db
Merge: dc15cca 81ce050
Author: Jiashun Zhu
AuthorDate: Sat Aug 28 1
This is an automated email from the ASF dual-hosted git repository.
jiashunzhu pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git.
from dc15cca Merge pull request #1536 from v1siuol/fix_get_brpc_revision
add 81ce050 Update oncall.md
zyearn commented on pull request #1539:
URL: https://github.com/apache/incubator-brpc/pull/1539#issuecomment-907623007
后续是不是把oncaller的github id也写上去，方便社区同学@
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
guodongxiaren edited a comment on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907601489
@zyearn 已经根据反馈修改了代码。有几个地方和你确认一下。
1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
2
guodongxiaren commented on pull request #1529:
URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907601489
已经根据反馈修改了代码。有几个地方和你确认一下。
1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://`
，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。
2. 当前的实现如果初始化的URL
28 matches
Mail list logo
