Re: Oncall report from Aug 23rd to Aug 29th

2021-08-31 Thread tan zhongyi
Thanks, Lorin, Have you modify the oncall list page also? BTW: would you please notify the next person who's oncall after you? 在 2021/9/1 上午10:52,“Lorin Lee” 写入: Hi all, The following PRs have been merged into master over the past week: * https://github.com/apache/incubator-brpc/p

[GitHub] [incubator-brpc] serverglen commented on pull request #1474: Supports customized tcp listener

2021-08-31 Thread GitBox
serverglen commented on pull request #1474: URL: https://github.com/apache/incubator-brpc/pull/1474#issuecomment-909932867 @zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] serverglen commented on pull request #1468: Implement FlatMap insert(const std::pair& kv)

2021-08-31 Thread GitBox
serverglen commented on pull request #1468: URL: https://github.com/apache/incubator-brpc/pull/1468#issuecomment-909932353 @zyearn @lorinlee @cdjingit @TousakaRin 辛苦抽时间review下呗,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-brpc] serverglen commented on pull request #1461: Implement brpc server Start(PortRange, const ServerOptions*)

2021-08-31 Thread GitBox
serverglen commented on pull request #1461: URL: https://github.com/apache/incubator-brpc/pull/1461#issuecomment-909931918 @zyearn @lorinlee @cdjingit @TousakaRin 辛苦帮review下呗,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-brpc] serverglen edited a comment on pull request #1483: Implement server eps bvar

2021-08-31 Thread GitBox
serverglen edited a comment on pull request #1483: URL: https://github.com/apache/incubator-brpc/pull/1483#issuecomment-906898534 > Related issue: #1482 > 目前brpcz中只有method级别的eps(error_per_second),本PR实现了server级别的eps。 > 其实server级别的eps对业务来说更为重要。 @lorinlee @zyearn @cdjingit @Tousaka

Oncall report from Aug 23rd to Aug 29th

2021-08-31 Thread Lorin Lee
Hi all, The following PRs have been merged into master over the past week: * https://github.com/apache/incubator-brpc/pull/1536 * https://github.com/apache/incubator-brpc/pull/1499 Besides, we passed the release vote in our community and proposed a vote in the incubator community. Our vote threa

[GitHub] [incubator-brpc] lorinlee merged pull request #1499: update docs

2021-08-31 Thread GitBox
lorinlee merged pull request #1499: URL: https://github.com/apache/incubator-brpc/pull/1499 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-un

[incubator-brpc] branch master updated (67589f4 -> 3b4d3b0)

2021-08-31 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 67589f4 Merge pull request #1542 from zyearn/update_oncall_githubid new 3fd288e update docs new

[GitHub] [incubator-brpc] serverglen commented on a change in pull request #1499: update docs

2021-08-31 Thread GitBox
serverglen commented on a change in pull request #1499: URL: https://github.com/apache/incubator-brpc/pull/1499#discussion_r698467641 ## File path: docs/cn/overview.md ## @@ -66,7 +66,7 @@ RPC不是万能的抽象,否则我们也不需要TCP/IP这一层了。但是 * 访问服务? 包含[brpc/channel.h](https://github.com/brpc/brp

[GitHub] [incubator-brpc] yujun411522 edited a comment on issue #1540: bRPC 在不同的PB版本,比如PB 2.5 和PB 3.8 性能表现

2021-08-31 Thread GitBox
yujun411522 edited a comment on issue #1540: URL: https://github.com/apache/incubator-brpc/issues/1540#issuecomment-908260490 > 如果差异只有pb的版本,那性能主要的差异也是pb本身吧。可以分别画个火焰图,做个差分火焰图看看cpu diff在哪里 这个是PB 2.5 的火焰图 [bRPC_pb2.5_perf.svg.zip](https://github.com/apache/incubator-brpc/files/707627

[GitHub] [incubator-brpc] lorinlee commented on a change in pull request #1499: update docs

2021-08-31 Thread GitBox
lorinlee commented on a change in pull request #1499: URL: https://github.com/apache/incubator-brpc/pull/1499#discussion_r698448671 ## File path: docs/cn/overview.md ## @@ -66,7 +66,7 @@ RPC不是万能的抽象,否则我们也不需要TCP/IP这一层了。但是 * 访问服务? 包含[brpc/channel.h](https://github.com/brpc/brpc/

[GitHub] [incubator-brpc] guodongxiaren commented on a change in pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

2021-08-31 Thread GitBox
guodongxiaren commented on a change in pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r698556520 ## File path: docs/en/http_client.md ## @@ -115,7 +115,9 @@ If user already sets `Host` header(case insensitive), framework makes no change.

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

2021-08-31 Thread GitBox
zyearn commented on a change in pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#discussion_r698818151 ## File path: docs/cn/http_client.md ## @@ -114,7 +114,9 @@ URL的一般形式如下图: 若用户没有填且URL中包含host,比如http://www.foo.com/path,则http request中会包含"Host: www

[GitHub] [incubator-brpc] zhangwenqin01 opened a new issue #1543: 开启cpu profiler后导出的pdf文件异常简洁

2021-08-31 Thread GitBox
zhangwenqin01 opened a new issue #1543: URL: https://github.com/apache/incubator-brpc/issues/1543 **Describe the bug (描述bug)**![image] 以echo_c++ server为例,使用方法: tools/pprof host:ip/pprof/profile --pdf > output.pdf 获取到的pdf如图所示 ![image](https://user-images.githubusercontent.com