[GitHub] [incubator-brpc] guodongxiaren commented on issue #1602: brpc有全面升级支持proto3的计划吗

2021-11-09 Thread GitBox
guodongxiaren commented on issue #1602: URL: https://github.com/apache/incubator-brpc/issues/1602#issuecomment-964871280 我们工作中用的就是proto3+brpc。一般不需要brpc升级吧。你用proto3编译brpc就行。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [incubator-brpc] zjhua68 opened a new issue #1602: brpc有全面升级支持proto3的计划吗

2021-11-09 Thread GitBox
zjhua68 opened a new issue #1602: URL: https://github.com/apache/incubator-brpc/issues/1602 用3.6版本的protobuf库生成proto2格式的pb,比生成的proto3格式的pb,在序列化和反序列化性能上大概差45%左右左右 目前市面上用grpc的用户或服务,基本都是proto3格式的pb了,如果考虑切换brpc,性能上基本没啥收益(因为上下游的架构不能统一切换,所以没法换成除pb之外的其他协议)。 brpc后续是否会全面支持proto3呢? --

[GitHub] [incubator-brpc] shanghx commented on issue #118: redis cluster access

2021-11-09 Thread GitBox
shanghx commented on issue #118: URL: https://github.com/apache/incubator-brpc/issues/118#issuecomment-964826372 > 你说的cluster是特指redis cluster吧,这个协议是可以基于基本的redis协议封装出来的,但目前brpc并不直接支持。你可以用专门的proxy做这个事情。 什么时候可以支持redis cluster呀,或者考虑支持redis cluster吗? -- This is an automated message from

[GitHub] [incubator-brpc] shanghx commented on issue #118: redis cluster access

2021-11-09 Thread GitBox
shanghx commented on issue #118: URL: https://github.com/apache/incubator-brpc/issues/118#issuecomment-964825904 什么时候可以支持redis cluster呀,或者考虑支持redis cluster吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-brpc] serverglen opened a new issue #1601: 关于实现bvar::WindowEx的几点想法

2021-11-09 Thread GitBox
serverglen opened a new issue #1601: URL: https://github.com/apache/incubator-brpc/issues/1601 # bvar::Window的问题? * bvar中的bvar::Window和bvar::PerSecond统计用起来不是很方便,依赖于一个单独的计数器 # bvar::WindowEx的实现思考 * 重新实现bvar::WindowEx和bvar::PerSecondEx用来替代bvar::Window和bvar::PerSecond *

[GitHub] [incubator-brpc] zyearn merged pull request #1599: Update http2_rpc_protocol.cpp

2021-11-09 Thread GitBox
zyearn merged pull request #1599: URL: https://github.com/apache/incubator-brpc/pull/1599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[incubator-brpc] branch master updated (73a2207 -> 317878f)

2021-11-09 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git. from 73a2207 Merge pull request #1590 from apache/1.0.0 new 6b40c24 Update http2_rpc_protocol.cpp

Re: [VOTE] Release Apache brpc (Incubating) 1.0.0

2021-11-09 Thread Jiashun Zhu
+1 On Tue, 9 Nov 2021 at 04:27, Wang Wei wrote: > +1 > > On Tue, Nov 9, 2021 at 10:58 AM Lorin Lee wrote: > > > Hello Apache brpc (Incubating) Community, > > > > > > > > This is a call for vote to release Apache brpc (Incubating) version 1.0.0 > > > > > > > > [Release Note] > > > >- > > >

[GitHub] [incubator-brpc] UncleWangNearBy opened a new issue #1600: dummy server在没有使用gflag的时候的问题

2021-11-09 Thread GitBox
UncleWangNearBy opened a new issue #1600: URL: https://github.com/apache/incubator-brpc/issues/1600 dummy server目前的界面看起来是固定的, 即使没有使用gflag也会显示flags按钮的页面。 但是如果没有使用gflag,点击flags的页面会直接core了。 建议在没有使用gflag时,隐藏flags按钮,或者点击按钮提示你没有使用gflag。 -- This is an automated message from the Apache Git

[GitHub] [incubator-brpc] guodongxiaren edited a comment on pull request #1433: Controller增加回调函数,用以支持在响应client之后,request/response析构之前执行一些自定义逻辑

2021-11-09 Thread GitBox
guodongxiaren edited a comment on pull request #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-963960851 > > > > > > > > 这个PR的目的是解决我之前提出的一个issue #1315 我们有一些场景,比如对response、request的整体(或其中大量字段)做落盘(比如经过某种序列化,然后把结果发送给kafka等MQ),

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1433: Controller增加回调函数,用以支持在响应client之后,request/response析构之前执行一些自定义逻辑

2021-11-09 Thread GitBox
guodongxiaren commented on pull request #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-963960851 > > > > > > > > 这个PR的目的是解决我之前提出的一个issue #1315 我们有一些场景,比如对response、request的整体(或其中大量字段)做落盘(比如经过某种序列化,然后把结果发送给kafka等MQ),

[GitHub] [incubator-brpc] foudreInSJTU commented on pull request #1433: Controller增加回调函数,用以支持在响应client之后,request/response析构之前执行一些自定义逻辑

2021-11-09 Thread GitBox
foudreInSJTU commented on pull request #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-963940050 > 这个PR的目的是解决我之前提出的一个issue #1315 我们有一些场景,比如对response、request的整体(或其中大量字段)做落盘(比如经过某种序列化,然后把结果发送给kafka等MQ),

[GitHub] [incubator-brpc] yanjianglu commented on a change in pull request #1599: Update http2_rpc_protocol.cpp

2021-11-09 Thread GitBox
yanjianglu commented on a change in pull request #1599: URL: https://github.com/apache/incubator-brpc/pull/1599#discussion_r745384487 ## File path: src/brpc/policy/http2_rpc_protocol.cpp ## @@ -204,7 +204,7 @@ bool ParseH2Settings(H2Settings* out, butil::IOBufBytesIterator&

[GitHub] [incubator-brpc] yanjianglu commented on a change in pull request #1599: Update http2_rpc_protocol.cpp

2021-11-09 Thread GitBox
yanjianglu commented on a change in pull request #1599: URL: https://github.com/apache/incubator-brpc/pull/1599#discussion_r745384487 ## File path: src/brpc/policy/http2_rpc_protocol.cpp ## @@ -204,7 +204,7 @@ bool ParseH2Settings(H2Settings* out, butil::IOBufBytesIterator&