[GitHub] [incubator-brpc] wasphin commented on a change in pull request #1723: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

wasphin commented on a change in pull request #1723: URL: https://github.com/apache/incubator-brpc/pull/1723#discussion_r838537945 ## File path: src/brpc/protocol.h ## @@ -56,6 +56,18 @@ class InputMessageBase; DECLARE_uint64(max_body_size); DECLARE_bool(log_error_text);

[GitHub] [incubator-brpc] wasphin commented on a change in pull request #1723: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

wasphin commented on a change in pull request #1723: URL: https://github.com/apache/incubator-brpc/pull/1723#discussion_r838537945 ## File path: src/brpc/protocol.h ## @@ -56,6 +56,18 @@ class InputMessageBase; DECLARE_uint64(max_body_size); DECLARE_bool(log_error_text);

[GitHub] [incubator-brpc] wwbmmm commented on a change in pull request #1723: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

wwbmmm commented on a change in pull request #1723: URL: https://github.com/apache/incubator-brpc/pull/1723#discussion_r838493161 ## File path: src/brpc/protocol.h ## @@ -56,6 +56,18 @@ class InputMessageBase; DECLARE_uint64(max_body_size); DECLARE_bool(log_error_text);

[GitHub] [incubator-brpc] wasphin commented on a change in pull request #1723: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

wasphin commented on a change in pull request #1723: URL: https://github.com/apache/incubator-brpc/pull/1723#discussion_r838459563 ## File path: src/brpc/protocol.h ## @@ -56,6 +56,18 @@ class InputMessageBase; DECLARE_uint64(max_body_size); DECLARE_bool(log_error_text);

[GitHub] [incubator-brpc] wasphin commented on a change in pull request #1723: Fix build warning, ByteSize() is deprecated, use ByteSizeLong() instead

wasphin commented on a change in pull request #1723: URL: https://github.com/apache/incubator-brpc/pull/1723#discussion_r838452430 ## File path: src/brpc/protocol.h ## @@ -56,6 +56,18 @@ class InputMessageBase; DECLARE_uint64(max_body_size); DECLARE_bool(log_error_text);

Re: [VOTE] Release Apache brpc (Incubating) 1.1.0

+1. Checked: [x] Download links are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each brpc repo. [x] All files have license headers if necessary. [x] No compiled archives bundled in source archive. On Tue, 29

[GitHub] [incubator-brpc] dboyzhong commented on issue #1731: brpc https client 偶现ssl 证书错误导致https请求失败

dboyzhong commented on issue #1731: URL: https://github.com/apache/incubator-brpc/issues/1731#issuecomment-1082809895 > > 1. SSL_Read循环读没问题，当第1次读成功，比如读到100字节数据，而循环再读第二次时，SSL_Read返回-1，此时append_from_SSL_channel是应该返回100？还是

[GitHub] [incubator-brpc] wwbmmm commented on issue #1731: brpc https client 偶现ssl 证书错误导致https请求失败

wwbmmm commented on issue #1731: URL: https://github.com/apache/incubator-brpc/issues/1731#issuecomment-1082783044 > 1. SSL_Read循环读没问题，当第1次读成功，比如读到100字节数据，而循环再读第二次时，SSL_Read返回-1，此时append_from_SSL_channel是应该返回100？还是 -1？因为毕竟读出来了100字节数据，返回-1是不是不太合适？（如果对端发送完这100字节后，对端发送RST分节，本端socket会返回-1）

[GitHub] [incubator-brpc] dboyzhong commented on issue #1731: brpc https client 偶现ssl 证书错误导致https请求失败

dboyzhong commented on issue #1731: URL: https://github.com/apache/incubator-brpc/issues/1731#issuecomment-1082759673 > 问题 好的，我正跟进wrong final block length 问题根因，这个问题还有一个逻辑上的问题请教： 1. SSL_Read循环读没问题，当第1次读成功，比如读到100字节数据，而循环再读第二次时，SSL_Read返回-1，此时append_from_SSL_channel是应该返回100？还是

[GitHub] [incubator-brpc] wwbmmm commented on issue #1731: brpc https client 偶现ssl 证书错误导致https请求失败

wwbmmm commented on issue #1731: URL: https://github.com/apache/incubator-brpc/issues/1731#issuecomment-1082680858 pappend_from_file_descriptor里只readv一次，是因为事先根据max_count分配了足够的内存空间，所以可以一次性把缓存区中的数据读出。 而SSL没有提供readv机制，所以在未读够max_count字节时，还是需要循环读取直到读不到数据或读取错误。