[GitHub] [incubator-brpc] zyearn closed issue #1779: libbrpc.so: undefined reference to `_dl_sym'

zyearn closed issue #1779: libbrpc.so: undefined reference to `_dl_sym' URL: https://github.com/apache/incubator-brpc/issues/1779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-brpc] zyearn merged pull request #1784: Fix _dl_sym undefined reference

zyearn merged PR #1784: URL: https://github.com/apache/incubator-brpc/pull/1784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[incubator-brpc] branch master updated: Fix _dl_sym undefined reference

This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new ded02c19 Fix _dl_sym undefined refer

[GitHub] [incubator-brpc] LostTong commented on issue #1727: Bthread: Lots of CPU cost on `do_futex` when running lightweight tasks

LostTong commented on issue #1727: URL: https://github.com/apache/incubator-brpc/issues/1727#issuecomment-1150877172 > > @mapleFU This is quite a good practice. Can you contribute a PR? That might help more people. > > Glad to contribute to brpc. But the code maybe ugly. I'll try to

[GitHub] [incubator-brpc] zyearn closed issue #1778: brpc对h2的实现存在死锁

zyearn closed issue #1778: brpc对h2的实现存在死锁 URL: https://github.com/apache/incubator-brpc/issues/1778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [incubator-brpc] zyearn commented on pull request #1433: Controller增加回调函数，用以支持在响应client之后，request/response析构之前执行一些自定义逻辑

zyearn commented on PR #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-1150910929 @guodongxiaren Sorry 之前漏掉这条了。Sync一下重新提一下？ @wwbmmm 之前baidu内部有类似的需求吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-brpc] zyearn opened a new issue, #1788: Feature request: Merge RDMA branch into master

zyearn opened a new issue, #1788: URL: https://github.com/apache/incubator-brpc/issues/1788 blockers: * Is RDMA stabilized? * Is code readable enough? * Are unit tests sufficient? Timeline: // TODO -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [incubator-brpc] lzfhust opened a new issue, #1789: thrift协议支持多参数-讨论

lzfhust opened a new issue, #1789: URL: https://github.com/apache/incubator-brpc/issues/1789 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 当前brpc对thrift协议，仅支持单个参数。thrift协议的多参数形式应用广泛，国内一些公司内部也在使用。希望brpc官方也能支持多参数 **Describe the solution you'd like (描述你期望的解决方法)**

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1433: Controller增加回调函数，用以支持在响应client之后，request/response析构之前执行一些自定义逻辑

wwbmmm commented on PR #1433: URL: https://github.com/apache/incubator-brpc/pull/1433#issuecomment-1150984793 > #1300 > @guodongxiaren Sorry 之前漏掉这条了。Sync一下重新提一下？ > > @wwbmmm 之前baidu内部有类似的需求吗 目前没有类似的需求 -- This is an automated message from the Apache Git Service.

[GitHub] [incubator-brpc] threadfly commented on a diff in pull request #495: support thrift rpc with multipule arguments

threadfly commented on code in PR #495: URL: https://github.com/apache/incubator-brpc/pull/495#discussion_r893478472 ## src/brpc/thrift_message.h: ## @@ -252,6 +273,34 @@ void ThriftStub::CallMethod(const char* method_name, } } -} // namespace brpc +template +void Thrif

[GitHub] [incubator-brpc] threadfly commented on pull request #495: support thrift rpc with multipule arguments

threadfly commented on PR #495: URL: https://github.com/apache/incubator-brpc/pull/495#issuecomment-1151102240 能支持了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [incubator-brpc] Sigma711 commented on issue #1693: compile failed with error "error: macro "__has_attribute" requires an identifier"

Sigma711 commented on issue #1693: URL: https://github.com/apache/incubator-brpc/issues/1693#issuecomment-1151542009 所以现在的解决方案是什么？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [incubator-brpc] Sigma711 commented on issue #1693: compile failed with error "error: macro "__has_attribute" requires an identifier"

Sigma711 commented on issue #1693: URL: https://github.com/apache/incubator-brpc/issues/1693#issuecomment-1151547858 > > > 有一个trick的方法，可以把`-D__const__=` 改成 `-D__const__=__unused__` 找了半天似乎就这个unused的attribute影响最小： https://user-images.githubusercontent.com/3894631/162140725-d0cea1d6-3e71-4f75-

[GitHub] [incubator-brpc] Sigma711 commented on pull request #1783: Fix __const__ compile error in gcc version >= 11.2.0

Sigma711 commented on PR #1783: URL: https://github.com/apache/incubator-brpc/pull/1783#issuecomment-1151552404 仍然不行，是要加什么选项吗？ ```txt -- Found gflags: /usr/lib/aarch64-linux-gnu/libgflags.so -- Configuring done -- Generating done -- Build files have been written to: /home/sigm

[GitHub] [incubator-brpc] wwbmmm commented on issue #1789: thrift协议支持多参数-讨论

wwbmmm commented on issue #1789: URL: https://github.com/apache/incubator-brpc/issues/1789#issuecomment-1151839834 之前有个PR，可以看看 #495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1783: Fix __const__ compile error in gcc version >= 11.2.0

wwbmmm commented on PR #1783: URL: https://github.com/apache/incubator-brpc/pull/1783#issuecomment-1151850954 > 仍然不行，是要加什么选项吗？ 我这边cmake编译是可以的。你用的是哪个commit的代码？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-brpc] lzfhust commented on issue #1789: thrift协议支持多参数-讨论

lzfhust commented on issue #1789: URL: https://github.com/apache/incubator-brpc/issues/1789#issuecomment-1151875174 此外，在ReadThriftStruct的时候，是不是得try-catch一下？我们发现，有可能会出现exception，进而导致core。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-brpc] lzfhust opened a new pull request, #1790: Thrift protocol exception

lzfhust opened a new pull request, #1790: URL: https://github.com/apache/incubator-brpc/pull/1790 我们发现，线上thrift协议，client端在ProcessThriftResponse的时候，出现偶发的core； 后来发现，是因为在ReadThriftStruct的时候，出现的exception，引发的。 所以，建议在ReadThriftStruct catch下，至少保证不会出core -- This is an automated message from

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1790: Thrift protocol exception

wwbmmm commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894130431 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -132,35 +132,38 @@ bool ReadThriftStruct(const butil::IOBuf& body, ::apache::thrift::transport::TMemoryB

[GitHub] [incubator-brpc] lzfhust commented on a diff in pull request #1790: Thrift protocol exception

lzfhust commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894135011 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -132,35 +132,38 @@ bool ReadThriftStruct(const butil::IOBuf& body, ::apache::thrift::transport::TMemory

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1790: Thrift protocol exception

wwbmmm commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894156200 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -161,8 +161,14 @@ bool ReadThriftStruct(const butil::IOBuf& body, xfer += iprot.readStructEnd();

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1790: Thrift protocol exception

wwbmmm commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894158323 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -161,8 +161,14 @@ bool ReadThriftStruct(const butil::IOBuf& body, xfer += iprot.readStructEnd();

[GitHub] [incubator-brpc] lzfhust commented on a diff in pull request #1790: Thrift protocol exception

lzfhust commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894167992 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -161,8 +161,14 @@ bool ReadThriftStruct(const butil::IOBuf& body, xfer += iprot.readStructEnd();

[GitHub] [incubator-brpc] lzfhust commented on a diff in pull request #1790: Thrift protocol exception

lzfhust commented on code in PR #1790: URL: https://github.com/apache/incubator-brpc/pull/1790#discussion_r894192867 ## src/brpc/policy/thrift_protocol.cpp: ## @@ -161,8 +161,14 @@ bool ReadThriftStruct(const butil::IOBuf& body, xfer += iprot.readStructEnd();

[GitHub] [incubator-brpc] wwbmmm opened a new pull request, #1791: Fix Acceptor::BeforeRecycle during Accept::StartAccept dead lock

wwbmmm opened a new pull request, #1791: URL: https://github.com/apache/incubator-brpc/pull/1791 Fix #1772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e