[GitHub] [incubator-brpc] Sigma711 closed issue #1816: Fail to build in Ubuntu 20.04 + GCC 11.2.0

2022-07-18 Thread GitBox
Sigma711 closed issue #1816: Fail to build in Ubuntu 20.04 + GCC 11.2.0 URL: https://github.com/apache/incubator-brpc/issues/1816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] chenBright commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-18 Thread GitBox
chenBright commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r924035287 ## src/brpc/selective_channel.cpp: ## @@ -223,6 +224,7 @@ void ChannelBalancer::RemoveAndDestroyChannel(SelectiveChannel::ChannelHandle ha

[GitHub] [incubator-brpc] chenBright commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-18 Thread GitBox
chenBright commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r924034863 ## src/brpc/selective_channel.cpp: ## @@ -189,6 +189,7 @@ int ChannelBalancer::AddChannel(ChannelBase* sub_channel, SocketOptions options;

[incubator-brpc] branch master updated: Fix UDS ut failed on MacOS

2022-07-18 Thread jamesge
This is an automated email from the ASF dual-hosted git repository. jamesge pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 30dfef16 Fix UDS ut failed on MacOS

[GitHub] [incubator-brpc] jamesge merged pull request #1843: Fix UDS ut failed on MacOS

2022-07-18 Thread GitBox
jamesge merged PR #1843: URL: https://github.com/apache/incubator-brpc/pull/1843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [incubator-brpc] zyearn commented on a diff in pull request #1814: fix ssl state exception coredump

2022-07-18 Thread GitBox
zyearn commented on code in PR #1814: URL: https://github.com/apache/incubator-brpc/pull/1814#discussion_r923810177 ## src/brpc/selective_channel.cpp: ## @@ -189,6 +189,7 @@ int ChannelBalancer::AddChannel(ChannelBase* sub_channel, SocketOptions options; options.user

[GitHub] [incubator-brpc] wasphin commented on issue #1816: Fail to build in Ubuntu 20.04 + GCC 11.2.0

2022-07-18 Thread GitBox
wasphin commented on issue #1816: URL: https://github.com/apache/incubator-brpc/issues/1816#issuecomment-1187190694 Fixed in master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] wwbmmm commented on issue #1844: 有支持proto3的计划吗?

2022-07-18 Thread GitBox
wwbmmm commented on issue #1844: URL: https://github.com/apache/incubator-brpc/issues/1844#issuecomment-1187036192 现在就是支持proto3的,你具体遇到什么不兼容问题,可以详细描述下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-brpc] jiangdongzi opened a new issue, #1844: 有支持proto3的计划吗?

2022-07-18 Thread GitBox
jiangdongzi opened a new issue, #1844: URL: https://github.com/apache/incubator-brpc/issues/1844 用到了proto3的都不兼容, 现在grpc基本都用proto3了吧? 这样的话, brpc对grpc的兼容没多少意义了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [incubator-brpc] eyun221 commented on issue #502: DoublyBufferedData扩展性受限于_SC_THREAD_KEYS_MAX只能到1024

2022-07-18 Thread GitBox
eyun221 commented on issue #502: URL: https://github.com/apache/incubator-brpc/issues/502#issuecomment-1186981651 > 好的,感谢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [incubator-brpc] zyearn opened a new issue, #1842: Integrate MacOS compilation into github actions

2022-07-18 Thread GitBox
zyearn opened a new issue, #1842: URL: https://github.com/apache/incubator-brpc/issues/1842 Problem: Currently when PR is merged, we can't ensure that it can be built and compiled in MacOS Solution: https://github.com/features/actions has already supported MacOS platform

[Result] [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread Shuai Liu
Hi all, The vote to release Apache brpc (Incubating) 1.2.0 has passed. The vote PASSED with 6 binding +1, 4 non binding +1 and 0 -1 votes: Binding votes: - Wang Weibing - Lorin Lee - He Lei - Yao Wang - James Ge - Jiashun Zhu Non-binding votes: - Wang Xiaofeng -

Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread Jiashun Zhu
+1 binding On Mon, 18 Jul 2022 at 09:10, James Ge wrote: > +1 binding > > Thanks > James Ge > > On Mon, Jul 18, 2022 at 3:02 PM fisherman wrote: > > > +1 (binding) > > > > Weibing Wang 于2022年7月11日周一 16:42写道: > > > > > +1 (binding) > > > > > > I have checked: > > > > > > [x] Download links

[Result] [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread Shuai Liu
Hi all, The vote to release Apache brpc (Incubating) 1.2.0 has passed. The vote PASSED with 5 binding +1, 4 non binding +1 and 0 -1 votes: Binding votes: - Weibing Wang - Li Lei - He Lei - Wang Yao - James Ge Non-binding votes: - Xiaofeng Wang - Xiguo Hu - Wang

Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread James Ge
+1 binding Thanks James Ge On Mon, Jul 18, 2022 at 3:02 PM fisherman wrote: > +1 (binding) > > Weibing Wang 于2022年7月11日周一 16:42写道: > > > +1 (binding) > > > > I have checked: > > > > [x] Download links are valid. > > [x] Checksums and GPG signatures are valid. > > [x] Source code distributions

Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread fisherman
+1 (binding) Weibing Wang 于2022年7月11日周一 16:42写道: > +1 (binding) > > I have checked: > > [x] Download links are valid. > [x] Checksums and GPG signatures are valid. > [x] Source code distributions have correct names matching the current > release. > [x] LICENSE and NOTICE files are correct for

Re: [VOTE] Release Apache brpc (Incubating) 1.2.0

2022-07-18 Thread He Lei
+1 (binding) I have checked: [x] Download links are valid. [x] Source code distributions have correct names matching the current release. [x] No compiled archives bundled in the source archive. Best regards, Lei He - To