[suggestion]update the bRPC users on website

2022-08-08 Thread Shuai Liu
Hi, all I suggest adding the following bRPC users on website: * 维沃(vivo) * 第四范式(4paradigm) * 小红书 * 作业帮 Ref: https://github.com/apache/incubator-brpc/blob/master/community/cases.md Best Regards, serverglen

Re: [discussion] 1.3.0 release features

2022-08-08 Thread Shuai Liu
maybe merge the following PRs: * implement bvar::WindowEx and bvar::PerSecondEx https://github.com/apache/incubator-brpc/pull/1603 * support channel option: health_check_path https://github.com/apache/incubator-brpc/pull/1806 * Fix bvar coredump bug caused by process exit https://github.com/apache/

Re: Introduction of ApacheCon Asia 2022 RPC track brpc session 1

2022-08-08 Thread Shuai Liu
Thanks for sharing. looking forward for the playbacks video. Best Regards, serverglen Jerry Tan 于2022年8月8日周一 08:15写道: > > Here is the link https://apachecon.com/acasia2022/sessions/rpc-1051.html > > presented by WangWeibing, PPMC of brpc. > > title : > BRPC: EVOLUTION OF RPC FRAMEWORKS IN THE CL

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940905290 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940905124 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] tsyw1987 commented on pull request #1836: enable brpc use rdma

2022-08-08 Thread GitBox
tsyw1987 commented on PR #1836: URL: https://github.com/apache/incubator-brpc/pull/1836#issuecomment-1208924101 后续是否支持同一个进程中启动多个brpc server,并分别绑定到不同的rdma网卡? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-brpc] darionyaphet commented on issue #1124: undefined reference to `google::protobuf::io::Printer::Print

2022-08-08 Thread GitBox
darionyaphet commented on issue #1124: URL: https://github.com/apache/incubator-brpc/issues/1124#issuecomment-1208867516 The new version does not have this problem. Maybe you can have a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-brpc] darionyaphet closed issue #1124: undefined reference to `google::protobuf::io::Printer::Print

2022-08-08 Thread GitBox
darionyaphet closed issue #1124: undefined reference to `google::protobuf::io::Printer::Print URL: https://github.com/apache/incubator-brpc/issues/1124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [incubator-brpc] wwbmmm commented on pull request #830: move thrift cmake build into cmake/FindThrift.cmake

2022-08-08 Thread GitBox
wwbmmm commented on PR #830: URL: https://github.com/apache/incubator-brpc/pull/830#issuecomment-1208860584 源repo被删,PR先close了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [incubator-brpc] wwbmmm closed pull request #830: move thrift cmake build into cmake/FindThrift.cmake

2022-08-08 Thread GitBox
wwbmmm closed pull request #830: move thrift cmake build into cmake/FindThrift.cmake URL: https://github.com/apache/incubator-brpc/pull/830 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [incubator-brpc] wwbmmm commented on pull request #766: fix ssl state check failed

2022-08-08 Thread GitBox
wwbmmm commented on PR #766: URL: https://github.com/apache/incubator-brpc/pull/766#issuecomment-1208859843 由于https://github.com/apache/incubator-brpc/pull/1814 已解决些问题,所以这个RP close了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [incubator-brpc] wwbmmm closed pull request #766: fix ssl state check failed

2022-08-08 Thread GitBox
wwbmmm closed pull request #766: fix ssl state check failed URL: https://github.com/apache/incubator-brpc/pull/766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [incubator-brpc] wwbmmm closed pull request #1276: fix rdma bond mode issue

2022-08-08 Thread GitBox
wwbmmm closed pull request #1276: fix rdma bond mode issue URL: https://github.com/apache/incubator-brpc/pull/1276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1276: fix rdma bond mode issue

2022-08-08 Thread GitBox
wwbmmm commented on PR #1276: URL: https://github.com/apache/incubator-brpc/pull/1276#issuecomment-1208858835 Hi, 我们后续计划不再维护单独的RDMA分支,而是将RDMA功能合入master,相关PR:https://github.com/apache/incubator-brpc/pull/1836 所以这个PR先close了。如果有关于RDMA的改进建议,可以在新的PR下讨论 -- This is an automated message from t

[GitHub] [incubator-brpc] wwbmmm closed pull request #1703: Fix rdma char buf overflow

2022-08-08 Thread GitBox
wwbmmm closed pull request #1703: Fix rdma char buf overflow URL: https://github.com/apache/incubator-brpc/pull/1703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1703: Fix rdma char buf overflow

2022-08-08 Thread GitBox
wwbmmm commented on PR #1703: URL: https://github.com/apache/incubator-brpc/pull/1703#issuecomment-1208858642 Hi, 我们后续计划不再维护单独的RDMA分支,而是将RDMA功能合入master,相关PR:https://github.com/apache/incubator-brpc/pull/1836 所以这个PR先close了。如果有关于RDMA的改进建议,可以在新的PR下讨论 -- This is an automated message from t

[GitHub] [incubator-brpc] wwbmmm closed pull request #1402: Fixed rdma multi device connect failed issue

2022-08-08 Thread GitBox
wwbmmm closed pull request #1402: Fixed rdma multi device connect failed issue URL: https://github.com/apache/incubator-brpc/pull/1402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1402: Fixed rdma multi device connect failed issue

2022-08-08 Thread GitBox
wwbmmm commented on PR #1402: URL: https://github.com/apache/incubator-brpc/pull/1402#issuecomment-1208858338 Hi, 我们后续计划不再维护单独的RDMA分支,而是将RDMA功能合入master,相关PR:https://github.com/apache/incubator-brpc/pull/1836 所以这个PR先close了。如果有关于RDMA的改进建议,可以在新的PR下讨论 -- This is an automated message from t

[GitHub] [incubator-brpc] wwbmmm closed pull request #1398: Rdma typo

2022-08-08 Thread GitBox
wwbmmm closed pull request #1398: Rdma typo URL: https://github.com/apache/incubator-brpc/pull/1398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1398: Rdma typo

2022-08-08 Thread GitBox
wwbmmm commented on PR #1398: URL: https://github.com/apache/incubator-brpc/pull/1398#issuecomment-1208858119 Hi, 我们后续计划不再维护单独的RDMA分支,而是将RDMA功能合入master,相关PR:https://github.com/apache/incubator-brpc/pull/1836 所以这个PR先close了。如果有关于RDMA的改进建议,可以在新的PR下讨论 -- This is an automated message from t

[incubator-brpc] branch master updated: update readme to add link to coc (#1564)

2022-08-08 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git The following commit(s) were added to refs/heads/master by this push: new 64957045 update readme to add link to co

[GitHub] [incubator-brpc] wwbmmm merged pull request #1564: update readme to add link to coc

2022-08-08 Thread GitBox
wwbmmm merged PR #1564: URL: https://github.com/apache/incubator-brpc/pull/1564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apa

[GitHub] [incubator-brpc] wwbmmm closed pull request #1774: Fix brpc client cannot reconnect to server probabilistically when the…

2022-08-08 Thread GitBox
wwbmmm closed pull request #1774: Fix brpc client cannot reconnect to server probabilistically when the… URL: https://github.com/apache/incubator-brpc/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-brpc] wwbmmm commented on pull request #1774: Fix brpc client cannot reconnect to server probabilistically when the…

2022-08-08 Thread GitBox
wwbmmm commented on PR #1774: URL: https://github.com/apache/incubator-brpc/pull/1774#issuecomment-1208856030 由于PR : https://github.com/apache/incubator-brpc/pull/1817 已经解决这个问题,所以这个PR close了。 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[discussion] 1.3.0 release features

2022-08-08 Thread Weibing Wang
Hi, all With the 1.2.0 release completed, we can consider the 1.3.0 release features. Over the past few releases, we've taken a relatively conservative approach and haven't merged large changes. Now that we have several stable releases, I think we can take a more aggressive strategy and merge some

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
wwbmmm commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940831991 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.

[incubator-brpc] branch release-1.2 created (now 29491107)

2022-08-08 Thread serverglen
This is an automated email from the ASF dual-hosted git repository. serverglen pushed a change to branch release-1.2 in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git at 29491107 Update CMakeLists.txt No new revisions were added by this update. ---

[incubator-brpc] branch master updated (6ad09c3d -> 3b7c711a)

2022-08-08 Thread jerrytan
This is an automated email from the ASF dual-hosted git repository. jerrytan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-brpc.git from 6ad09c3d Fix currently broken MacOS build (#1871) new 946d29b6 Update README.md new 2c68ab97 Updat

[GitHub] [incubator-brpc] tanzhongyi003 merged pull request #1879: Update brpc introduction

2022-08-08 Thread GitBox
tanzhongyi003 merged PR #1879: URL: https://github.com/apache/incubator-brpc/pull/1879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@b

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940171378 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940156459 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940154870 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] serverglen commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
serverglen commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940154039 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreemen

[GitHub] [incubator-brpc] TousakaRin commented on issue #1870: 使用example中的例子验证熔断功能(可选熔断和连接超时熔断)

2022-08-08 Thread GitBox
TousakaRin commented on issue #1870: URL: https://github.com/apache/incubator-brpc/issues/1870#issuecomment-1207770415 检查一下是否有Socket[xxx] isolated by circuit breaker 的log,brpc的默认重连方式只需要tcp能够建立连接,有可能熔断之后又恢复了。 另外connections监控页面也可以检查各个连接的健康状况。 连接超时的熔断需要用iptables drop掉对应端口的包,直接sleep是不