[GitHub] [brpc] lorinlee commented on issue #2084: my_ip_cstr获取本机ip为127.0.0.1

2023-01-15 Thread GitBox
lorinlee commented on issue #2084: URL: https://github.com/apache/brpc/issues/2084#issuecomment-1383112440 @xiaohei520321 获取不到ip的服务器上,hosts文件里有写127.0.0.1吗,删掉看可以不 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [brpc] lorinlee merged pull request #2083: typo fix for bthread introduction

2023-01-15 Thread GitBox
lorinlee merged PR #2083: URL: https://github.com/apache/brpc/pull/2083 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[brpc] branch master updated: typo fix for bthread introduction

2023-01-15 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 518d216d typo fix for bthread introduction

[GitHub] [brpc] lorinlee merged pull request #2047: Keep bthread TaskGroup abi compatible with NDEBUG macro

2023-01-15 Thread GitBox
lorinlee merged PR #2047: URL: https://github.com/apache/brpc/pull/2047 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[brpc] branch master updated: Keep bthread TaskGroup abi compatible with NDEBUG macro

2023-01-15 Thread lorinlee
This is an automated email from the ASF dual-hosted git repository. lorinlee pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 3a82c275 Keep bthread TaskGroup abi compatible w

[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383136246 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。 -- This is an

[GitHub] [brpc] jenrryyou opened a new pull request, #2086: Fix butex wait_pthread handle EINTR

2023-01-15 Thread GitBox
jenrryyou opened a new pull request, #2086: URL: https://github.com/apache/brpc/pull/2086 wait_pthread处理被信号中断的情况。 没有这个处理之前,假设butex_wait_from_pthread的timeout设置为100s,但是这个线程每隔10s会被信号中断(如正在进行profile,会定时中断采集线程堆栈),futex_wait_private会返回EINTR,导致butex_wait_from_pthread永远不会超时返回。 -- This is an au

[GitHub] [brpc] wwbmmm commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
wwbmmm commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383350427 > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。 使用的是mast

[GitHub] [brpc] yanglimingcn opened a new pull request, #2087: add max concurrency for timeout concurrency limiter

2023-01-15 Thread GitBox
yanglimingcn opened a new pull request, #2087: URL: https://github.com/apache/brpc/pull/2087 基于延迟的并发控制,在average latency的统计还没有刷新的时候,有可能因为一些慢请求导致服务排队很多请求,这个最大并发的设置,可以在这种情况下保护服务不被太多的请求压垮。 @wwbmmm 请PR -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [brpc] ysj1173886760 commented on issue #845: 在aarch64下编译之后,运行会触发 LOG(FATAL) << "bthread=" << g->current_tid() << " sched_to itself!"; 请问下哪种情况下会有这个情况?

2023-01-15 Thread GitBox
ysj1173886760 commented on issue #845: URL: https://github.com/apache/brpc/issues/845#issuecomment-1383387003 > > 在Mac M1上也遇到了相同的问题。在并发数偏高的时候会出现`sched_to itself`的错误。 > > 尝试去除掉这次修改中的`if #define(_linux_)`后问题仍然存在。 > > 奇怪的是在我把我自己的项目设置成Release模式构建之后,就不会出现`sched_to itself`的错误了。 > > 使用的

[GitHub] [brpc] yanglimingcn commented on issue #2013: 基于请求延迟的并发控制

2023-01-15 Thread GitBox
yanglimingcn commented on issue #2013: URL: https://github.com/apache/brpc/issues/2013#issuecomment-1383417016 OK,等我有时间补充一下哈 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [brpc] wwbmmm commented on a diff in pull request #2086: Fix butex wait_pthread handle EINTR

2023-01-15 Thread GitBox
wwbmmm commented on code in PR #2086: URL: https://github.com/apache/brpc/pull/2086#discussion_r1070816953 ## src/bthread/butex.cpp: ## @@ -137,7 +137,21 @@ static void wakeup_pthread(ButexPthreadWaiter* pw) { bool erase_from_butex(ButexWaiter*, bool, WaiterState); -int wai

[GitHub] [brpc] wasphin opened a new pull request, #2088: Explicitly listing all third-part licensed files

2023-01-15 Thread GitBox
wasphin opened a new pull request, #2088: URL: https://github.com/apache/brpc/pull/2088 ### What problem does this PR solve? Issue Number: NONE Problem Summary: ### What is changed and the side effects? Changed: Update LICENSE to list files porting from Chromium

[GitHub] [brpc] wwbmmm merged pull request #2088: Explicitly listing all third-part licensed files

2023-01-15 Thread GitBox
wwbmmm merged PR #2088: URL: https://github.com/apache/brpc/pull/2088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated: Explicitly listing all third-part licensed files (#2088)

2023-01-15 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 0448075c Explicitly listing all third-part license

[GitHub] [brpc] cdjingit opened a new pull request, #2089: WIP: fix doc && code style

2023-01-15 Thread GitBox
cdjingit opened a new pull request, #2089: URL: https://github.com/apache/brpc/pull/2089 ### What problem does this PR solve? fix code style and doc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [brpc] wwbmmm merged pull request #2089: WIP: fix doc && code style

2023-01-15 Thread GitBox
wwbmmm merged PR #2089: URL: https://github.com/apache/brpc/pull/2089 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated: fix doc && code style (#2089)

2023-01-15 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 645cebd2 fix doc && code style (#2089) 645cebd2 is

[GitHub] [brpc] wwbmmm merged pull request #2087: add max concurrency for timeout concurrency limiter

2023-01-15 Thread GitBox
wwbmmm merged PR #2087: URL: https://github.com/apache/brpc/pull/2087 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated: add max concurrency for timeout concurrency limiter (#2087)

2023-01-15 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new c9dc47a0 add max concurrency for timeout concurren