[PR] Fix core when ssl is enabled (brpc)

2023-03-27 Thread via GitHub
warriorpaw opened a new pull request, #2180: URL: https://github.com/apache/brpc/pull/2180 OpenSSL does not guarantee that any of its objects can be used concurrently by multiple threads: https://github.com/openssl/openssl/issues/2165 https://github.com/openssl/openssl/issues/20446

Re: [I] brpc故障恢复bug (brpc)

2023-03-27 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485021340 > 请问“网络重启故障”具体是指什么呢?是如何注入的?我们也遇到了这个问题,client一直返回E112,直到重启才恢复,持续时间最长的client大约是40分钟。 就是执行 service network restart -- This is an automated message from the Apache Git Service.

Re: [I] brpc故障恢复bug (brpc)

2023-03-27 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485037941 我升级到了brpc1.4版本,依然没有解决这个问题,不断注入网络故障:ifconfig down/up bond的一个口,又复现了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] brpc故障恢复bug (brpc)

2023-03-27 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485044876 这个问题对目前的业务影响很大,比较头疼。我想到的办法是: 1.放弃使用brpc,改用grpc,但是grpc没brpc好,c++的grpc太臃肿了 2.改源码,把Socket类改写掉,去掉那一堆复杂的原子计数,用最简单的方式实现 3.应用层规避,brpc持续出现这个错误码,进程就自杀(把channel delete掉,重连,不知道是否有效果) -

Re: [I] brpc故障恢复bug (brpc)

2023-03-27 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485045065 这个问题对目前的业务影响很大,比较头疼。我想到的办法是: 1.放弃使用brpc,改用grpc,但是grpc没brpc好,c++的grpc太臃肿了 2.改源码,把Socket类改写掉,去掉那一堆复杂的原子计数,用最简单的方式实现 3.应用层规避,brpc持续出现这个错误码,进程就自杀(把channel delete掉,重连,不知道是否有效果) -

Re: [I] brpc故障恢复bug (brpc)

2023-03-27 Thread via GitHub
netjia-cpu commented on issue #2146: URL: https://github.com/apache/brpc/issues/2146#issuecomment-1485045503 这个问题对目前的业务影响很大,比较头疼。我想到的办法是: 1.放弃使用brpc,改用grpc,但是grpc没brpc好,c++的grpc太臃肿了 2.改源码,把Socket类改写掉,去掉那一堆复杂的原子计数,用最简单的方式实现 3.应用层规避,brpc持续出现这个错误码,进程就自杀(把channel delete掉,重连,不知道是否有效果) -

[PR] Fix comment typo in DataFactory (brpc)

2023-03-27 Thread via GitHub
chenBright opened a new pull request, #2181: URL: https://github.com/apache/brpc/pull/2181 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

[I] support rvalue in bthread::execution_queue_execute (brpc)

2023-03-27 Thread via GitHub
qiuhuiming opened a new issue, #2182: URL: https://github.com/apache/brpc/issues/2182 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** In some scenario, the task structures do not have copy constructor, but have move constructor. In this case, we cannot use the `e

Re: [I] 使用asan检查程序内存时,brpc服务端函数内部的heap-use-after-free,无法提示内存被释放的完整堆栈 (brpc)

2023-03-27 Thread via GitHub
warriorpaw commented on issue #2172: URL: https://github.com/apache/brpc/issues/2172#issuecomment-1485376483 增加--usercode_in_pthread=true参数再执行,asan的堆栈应该就是完整的,see: https://github.com/google/sanitizers/issues/189 ,asan不支持swapcontext,但是 bthread就是基于swapcontext 实现的,usercode_in_pthread参数会让brpc在pt

[PR] Update CI check in CONTRIBUTING.md (brpc)

2023-03-27 Thread via GitHub
kiminno opened a new pull request, #2183: URL: https://github.com/apache/brpc/pull/2183 ### What problem does this PR solve? Issue Number: N/A Problem Summary: - A Travis CI build was last run 4 months ago, however, it is still mentioned in the contributing guidelines. The n

Re: [PR] Fix comment typo in DataFactory (brpc)

2023-03-27 Thread via GitHub
wwbmmm merged PR #2181: URL: https://github.com/apache/brpc/pull/2181 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated: Fix comment typo in DataFactory (#2181)

2023-03-27 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 2453cd8d Fix comment typo in DataFactory (#2181) 2

Re: [PR] Update CI check in CONTRIBUTING.md (brpc)

2023-03-27 Thread via GitHub
wwbmmm merged PR #2183: URL: https://github.com/apache/brpc/pull/2183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated (2453cd8d -> 2bf7680d)

2023-03-27 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git from 2453cd8d Fix comment typo in DataFactory (#2181) add 2bf7680d Update CI check in CONTRIBUTING.md (#2183) No new re

Re: [I] 使用asan检查程序内存时,brpc服务端函数内部的heap-use-after-free,无法提示内存被释放的完整堆栈 (brpc)

2023-03-27 Thread via GitHub
zzjshaok commented on issue #2172: URL: https://github.com/apache/brpc/issues/2172#issuecomment-1486093174 > 增加--usercode_in_pthread=true命令行参数再执行,asan的堆栈应该就是完整的,see: [google/sanitizers#189](https://github.com/google/sanitizers/issues/189) ,asan不支持swapcontext,但是 bthread就是基于swapcontext 实现的,u

Re: [I] 使用asan检查程序内存时,brpc服务端函数内部的heap-use-after-free,无法提示内存被释放的完整堆栈 (brpc)

2023-03-27 Thread via GitHub
zzjshaok closed issue #2172: 使用asan检查程序内存时,brpc服务端函数内部的heap-use-after-free,无法提示内存被释放的完整堆栈 URL: https://github.com/apache/brpc/issues/2172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix core when ssl is enabled (brpc)

2023-03-27 Thread via GitHub
wwbmmm commented on PR #2180: URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486094743 Does this affect performance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Fix domain naming service host name buffer length (brpc)

2023-03-27 Thread via GitHub
wwbmmm merged PR #2179: URL: https://github.com/apache/brpc/pull/2179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

[brpc] branch master updated: Fix domain naming service host name buffer length (#2179)

2023-03-27 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 5d155f57 Fix domain naming service host name buffe

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-03-27 Thread via GitHub
wwbmmm commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-1486096576 CI单测失败了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix core when ssl is enabled (brpc)

2023-03-27 Thread via GitHub
jingshi-ant commented on PR #2180: URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486100599 > Does this affect performance? about 20% slower in my 100w data set test. (mainly because of ssl enable. if remove lock and enable ssl, the speed is almost the same with lock adde

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-03-27 Thread via GitHub
Huixxi commented on code in PR #2177: URL: https://github.com/apache/brpc/pull/2177#discussion_r1149950048 ## src/brpc/controller.cpp: ## @@ -719,6 +719,37 @@ inline bool does_error_affect_main_socket(int error_code) { error_code == EINVAL/*returned by connect "0.0.0.1"

Re: [PR] Fix #2146 E112 EHOSTDOWN in short and pooled connection (brpc)

2023-03-27 Thread via GitHub
Huixxi commented on PR #2177: URL: https://github.com/apache/brpc/pull/2177#issuecomment-1486102286 > CI单测失败了 嗯嗯。。 我先在本地调试一下。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] fix: lalb.md (brpc)

2023-03-27 Thread via GitHub
wy1433 opened a new pull request, #2184: URL: https://github.com/apache/brpc/pull/2184 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [PR] fix: lalb.md (brpc)

2023-03-27 Thread via GitHub
serverglen commented on PR #2184: URL: https://github.com/apache/brpc/pull/2184#issuecomment-1486126613 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[brpc] branch master updated: Update lalb.md (#2184)

2023-03-27 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new c1e83cf2 Update lalb.md (#2184) c1e83cf2 is descri

Re: [PR] fix: lalb.md (brpc)

2023-03-27 Thread via GitHub
wwbmmm merged PR #2184: URL: https://github.com/apache/brpc/pull/2184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

Re: [I] 是否有计划支持zstd压缩? (brpc)

2023-03-27 Thread via GitHub
serverglen commented on issue #2174: URL: https://github.com/apache/brpc/issues/2174#issuecomment-1486129388 暂时没有计划,bRPC中的压缩算法是可扩展的,有兴趣的话欢迎给bRPC提交PR,可以参考snappy,zlib,gzip的视线。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Fix core when ssl is enabled (brpc)

2023-03-27 Thread via GitHub
warriorpaw commented on PR #2180: URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486138968 > Does this affect performance? Brpc already piped write requests by linked list and only one bthread calls ssl_write. In data reading, brpc use epoll in edge triggered mode