Re: [I] brpcServer 异步处理 (brpc)

2023-11-21 Thread via GitHub
leaf-potato commented on issue #2446: URL: https://github.com/apache/brpc/issues/2446#issuecomment-1822183144 > > 那么是在Echo 处理函数中回复了Echo response,同时启动一个线程来运行你的业务函数就行了吧 > > 想了解brpc有没有预留这样的借口,自己起线程,感觉在程序退出时,可能会有资源访问core问题 运行done->Run()后request和response都会被析构,如果在单独业务线程中会访问req和resp会有问

Re: [I] brpcServer 异步处理 (brpc)

2023-11-21 Thread via GitHub
yming000 commented on issue #2446: URL: https://github.com/apache/brpc/issues/2446#issuecomment-1822018186 > 看下这个#2328 满足需求吗 谢谢 我学习一下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

Re: [PR] add wrr lb fallback strategy (brpc)

2023-11-21 Thread via GitHub
chenBright commented on PR #2441: URL: https://github.com/apache/brpc/pull/2441#issuecomment-182298 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] lalb try left server nodes (brpc)

2023-11-21 Thread via GitHub
chenBright commented on PR #2428: URL: https://github.com/apache/brpc/pull/2428#issuecomment-1821998620 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Support max width of flame graph image (brpc)

2023-11-21 Thread via GitHub
chenBright opened a new pull request, #2452: URL: https://github.com/apache/brpc/pull/2452 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

[PR] Opt ssl read log (brpc)

2023-11-21 Thread via GitHub
chenBright opened a new pull request, #2451: URL: https://github.com/apache/brpc/pull/2451 ### What problem does this PR solve? Issue Number: #977 Problem Summary: 对端发送完数据后关闭连接或者shutdown ssl,就有可能出现ssl_error=SSL_ERROR_SYSCALL/SSL_ERROR_ZERO_RETURN、nr>0、e=0,这应该是正常情况,没有必要打印

Re: [I] brpcServer 异步处理 (brpc)

2023-11-21 Thread via GitHub
yming000 commented on issue #2446: URL: https://github.com/apache/brpc/issues/2446#issuecomment-1820743780 > 那么是在Echo 处理函数中回复了Echo response,同时启动一个线程来运行你的业务函数就行了吧 想了解brpc有没有预留这样的借口,自己起线程,感觉在程序退出时,可能会有资源访问core问题 -- This is an automated message from the Apache Git Service. To respond t