Re: [PR] bthread task group add tag (brpc)

2023-12-13 Thread via GitHub
vinllen commented on PR #2358: URL: https://github.com/apache/brpc/pull/2358#issuecomment-1853485155 坐等合入 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

Re: [PR] bthread task group add tag (brpc)

2023-12-13 Thread via GitHub
huntinux commented on PR #2358: URL: https://github.com/apache/brpc/pull/2358#issuecomment-1853514284 > 大佬们这个现在有啥合并 master 的计划吗?有了 tag 也好支持 NUMA 分组了,不然大机型搞起来还有点费劲 @justmao945 @yanglimingcn @wwbmmm 我请教个小问题,大机型下,如果划分容器时直接绑定numa,这样就没有 remote access 了。在软件层面实现 numa aware 似乎只能逼近这个状态。所以为什么不

Re: [I] 有社区交流群吗 (brpc)

2023-12-13 Thread via GitHub
limindlmu commented on issue #1241: URL: https://github.com/apache/brpc/issues/1241#issuecomment-1853561314 @gydong vx:cflimi ,求拉社区交流群 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] remove the docs and comments related to HealthCheckThread (brpc)

2023-12-13 Thread via GitHub
Divyansh200102 commented on issue #1209: URL: https://github.com/apache/brpc/issues/1209#issuecomment-1854656746 Can anyone review the pr? @zyearn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] remove the docs and comments related to HealthCheckThread (brpc)

2023-12-13 Thread via GitHub
zyearn closed issue #1209: remove the docs and comments related to HealthCheckThread URL: https://github.com/apache/brpc/issues/1209 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] remove the docs and comments related to HealthCheckThread (brpc)

2023-12-13 Thread via GitHub
zyearn merged PR #2463: URL: https://github.com/apache/brpc/pull/2463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: remove the docs and comments related to HealthCheckThread (#2463)

2023-12-13 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new a665f60d remove the docs and comments related

Re: [PR] bthread task group add tag (brpc)

2023-12-13 Thread via GitHub
yanglimingcn commented on PR #2358: URL: https://github.com/apache/brpc/pull/2358#issuecomment-1854982265 > > 大佬们这个现在有啥合并 master 的计划吗?有了 tag 也好支持 NUMA 分组了,不然大机型搞起来还有点费劲 > > @justmao945 @yanglimingcn @wwbmmm 我请教个小问题,大机型下,如果划分容器时直接绑定numa,这样就没有 remote access 了。在软件层面实现 numa aware 似乎只能逼近这

Re: [PR] fix window update threshold (brpc)

2023-12-13 Thread via GitHub
wwbmmm merged PR #2418: URL: https://github.com/apache/brpc/pull/2418 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org F

(brpc) branch master updated: fix window update threshold (#2418)

2023-12-13 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 249df0f3 fix window update threshold (#2418) 249df

Re: [I] Remove implementation specific function name of EventDispatcher (brpc)

2023-12-13 Thread via GitHub
Divyansh200102 commented on issue #1894: URL: https://github.com/apache/brpc/issues/1894#issuecomment-1855094311 Please review this pr as well @zyearn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g