Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-02-04 Thread via GitHub
zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1926332705 另外还有一个疑问是，函数 task_runner 和 tls_task_group 不都是在一个编译单元内吗？为什么是开启lto后才会触发这个问题呢。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-02-04 Thread via GitHub
ehds commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1926276260 > 感觉还是 thread_local 读写的问题， 请问下除了这个patch外，后面还有其他关于这个问题的修复吗？ 目前去掉 `src/bthread/task_group.cpp` 的lto后，可以正常工作。 > > task_runner 循环外的 tls，也加上 BAIDU_GET_VOLATILE_THREAD_LOCAL，后似乎问题不再出现了。 >

Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-02-04 Thread via GitHub
zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1926165119 感觉还是 thread_local 读写的问题， 请问下除了这个patch外，后面还有其他关于这个问题的修复吗？ 目前去掉 `src/bthread/task_group.cpp` 的lto后，可以正常工作。 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] span for new bthread (brpc)

2024-02-04 Thread via GitHub
yanglimingcn commented on PR #2519: URL: https://github.com/apache/brpc/pull/2519#issuecomment-1926075788 @wwbmmm 这个PR有时间可以review了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] 使用brpc提供的rpc_press进行性能测试，求问极限QPS (brpc)

2024-02-04 Thread via GitHub
Superskyyy commented on issue #2533: URL: https://github.com/apache/brpc/issues/2533#issuecomment-1925902304 > > @wonderhelios 你好 我们也对性能很感兴趣,请问可以分享出来测试用的代码吗 我这也想跑一下 > > client是简单的改动了一下brpc提供的rpc_press工具，同步模式，命令在上面给出了，server是直接启的brpc中的echo_server。 rpc_press的改动如下： > >

Re: [VOTE] Release Apache bRPC 1.8.0

2024-02-04 Thread Jiashun Zhu
+1 (binding) I have checked: [x] Download links are valid. [x] Checksums and PGP signatures are valid. [x] Source code distributions have correct names matching the current release. [x] LICENSE and NOTICE files are correct for each brpc repo. [x] All files have license headers if necessary. [x]

Oncall report Jan. 29th-Feb.4th

2024-02-04 Thread Jiashun Zhu
Hi all, Over the past one week, the following PR was merged: * https://github.com/apache/brpc/pull/2521([Fuzzing] add cifuzz workflow #2521) Thanks, Jiashun

(brpc) branch master updated: [Fuzzing] add cifuzz (#2521)

2024-02-04 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new fa978855 [Fuzzing] add cifuzz (#2521)

Re: [PR] [Fuzzing] add cifuzz workflow (brpc)

2024-02-04 Thread via GitHub
zyearn merged PR #2521: URL: https://github.com/apache/brpc/pull/2521 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-02-04 Thread via GitHub
zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1925685544 目前还没无法构造一个最小示例。 在加上这个commit的修改后，AddressSanitizer 会提示 heap-use-after-free，不过不会显示释放的位置, 使用 `--usercode_in_pthread` 就无法复现这个错误了。 ``` ==31802==ERROR: AddressSanitizer: heap-use-after-free

Re: [PR] fix compiler optimize thread local variable access (brpc)

2024-02-04 Thread via GitHub
zcfh commented on PR #2156: URL: https://github.com/apache/brpc/pull/2156#issuecomment-1925685023 目前还没无法构造一个最小示例。 在加上这个commit的修改后，AddressSanitizer 会提示 heap-use-after-free，不过不会显示释放的位置, 使用 `--usercode_in_pthread` 就无法复现这个错误了。 ``` ==31802==ERROR: AddressSanitizer: heap-use-after-free