Re: [I] 编译example/parallel_echo_c++ 出错 (brpc)

2024-03-11 Thread via GitHub
sherlock-wong commented on issue #167: URL: https://github.com/apache/brpc/issues/167#issuecomment-1990745834 it dosen't work!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comme

Re: [PR] Support shutdown write and notify for success write (brpc)

2024-03-11 Thread via GitHub
chenBright commented on PR #2547: URL: https://github.com/apache/brpc/pull/2547#issuecomment-1989867995 @wwbmmm 有空看看这个PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

(brpc) branch master updated: Fix random value of CachedReader at first time (#2556)

2024-03-11 Thread serverglen
This is an automated email from the ASF dual-hosted git repository. serverglen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 965279f0 Fix random value of CachedReader at f

Re: [PR] Fix random value of CachedReader at first time (brpc)

2024-03-11 Thread via GitHub
serverglen merged PR #2556: URL: https://github.com/apache/brpc/pull/2556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Re: [PR] Fix random value of CachedReader at first time (brpc)

2024-03-11 Thread via GitHub
serverglen commented on PR #2556: URL: https://github.com/apache/brpc/pull/2556#issuecomment-1989844093 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(brpc) branch master updated: Fix cancel callback may be called twice (#2557)

2024-03-11 Thread serverglen
This is an automated email from the ASF dual-hosted git repository. serverglen pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 17a200c2 Fix cancel callback may be called twi

Re: [PR] Fix cancel callback may be called twice (brpc)

2024-03-11 Thread via GitHub
serverglen merged PR #2557: URL: https://github.com/apache/brpc/pull/2557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.or

Oncall report from Mar 4th to Mar 10th

2024-03-11 Thread he lei
Hi all: During last week, 3 issues were resolved, and 1 pr is merged: - https://github.com/apache/brpc/pull/2553 -- Best regards, he lei lhe...@163.com - To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additiona

Re: [PR] Support IOBuf Profiler (brpc)

2024-03-11 Thread via GitHub
chenBright commented on code in PR #2497: URL: https://github.com/apache/brpc/pull/2497#discussion_r1520078390 ## src/butil/iobuf_profiler.cpp: ## @@ -0,0 +1,307 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See th

Re: [PR] Support on_failed callback for streaming rpc (brpc)

2024-03-11 Thread via GitHub
chenBright commented on code in PR #2565: URL: https://github.com/apache/brpc/pull/2565#discussion_r1519848826 ## src/brpc/stream.h: ## @@ -44,7 +44,18 @@ class StreamInputHandler { butil::IOBuf *const messages[],

Re: [PR] Support on_failed callback for streaming rpc (brpc)

2024-03-11 Thread via GitHub
chenBright commented on code in PR #2565: URL: https://github.com/apache/brpc/pull/2565#discussion_r1519833776 ## src/brpc/stream.h: ## @@ -44,7 +44,18 @@ class StreamInputHandler { butil::IOBuf *const messages[],

Re: [PR] Support on_failed callback for streaming rpc (brpc)

2024-03-11 Thread via GitHub
chenBright commented on code in PR #2565: URL: https://github.com/apache/brpc/pull/2565#discussion_r1519833776 ## src/brpc/stream.h: ## @@ -44,7 +44,18 @@ class StreamInputHandler { butil::IOBuf *const messages[],

[PR] Get gcc version by script to support cross-compile (brpc)

2024-03-11 Thread via GitHub
wasphin opened a new pull request, #2567: URL: https://github.com/apache/brpc/pull/2567 Fix #1631 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance eff