Re: [PR] update oncall list [brpc-website]

2024-04-28 Thread via GitHub
wwbmmm merged PR #170: URL: https://github.com/apache/brpc-website/pull/170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] update oncall list [brpc-website]

2024-04-28 Thread via GitHub
wwbmmm opened a new pull request, #170: URL: https://github.com/apache/brpc-website/pull/170 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

(brpc) branch master updated: Fix FlatMap assign operator bug (#2622)

2024-04-28 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new f97cbe5c Fix FlatMap assign operator bug (#2622)

Re: [PR] Fix FlatMap assign operator bug (brpc)

2024-04-28 Thread via GitHub
wwbmmm merged PR #2622: URL: https://github.com/apache/brpc/pull/2622 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [I] 支持python吗? (brpc)

2024-04-28 Thread via GitHub
wwbmmm commented on issue #2619: URL: https://github.com/apache/brpc/issues/2619#issuecomment-2081783191 不支持python,也没有计划支持 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [I] 支持python吗? (brpc)

2024-04-28 Thread via GitHub
wwbmmm closed issue #2619: 支持python吗? URL: https://github.com/apache/brpc/issues/2619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

(brpc) branch master updated: Update protobuf version in doc (#2618)

2024-04-28 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 0128bb11 Update protobuf version in doc (#2618)

Re: [PR] Update protobuf version in doc (brpc)

2024-04-28 Thread via GitHub
wwbmmm merged PR #2618: URL: https://github.com/apache/brpc/pull/2618 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [PR] remove old rpcz directory even if program crash (brpc)

2024-04-28 Thread via GitHub
wwbmmm commented on code in PR #2610: URL: https://github.com/apache/brpc/pull/2610#discussion_r1582486422 ## src/brpc/span.cpp: ## @@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) { } SpanDB* SpanDB::Open() { +// Remove old rpcz directory even

(brpc) branch master updated: Release 1.9.0 (#2616)

2024-04-28 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 58cc798b Release 1.9.0 (#2616) 58cc798b is

Re: [PR] Release 1.9.0 (brpc)

2024-04-28 Thread via GitHub
wwbmmm merged PR #2616: URL: https://github.com/apache/brpc/pull/2616 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

(brpc) branch master updated: Fix incorrect core file found in run_tests.sh (#2614)

2024-04-28 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 72303471 Fix incorrect core file found in

Re: [PR] support bthread primitive cross different worker pools (brpc)

2024-04-28 Thread via GitHub
yanglimingcn commented on PR #2551: URL: https://github.com/apache/brpc/pull/2551#issuecomment-2081780448 > @yanglimingcn 请问这个PR是意味着可以跨tag使用bthread同步原语了吗? 使用中是否还有需要在注意的问题呢? 是的,使用过程中没有什么要注意的,和原来的语义保持一致。 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Fix max concurrency of thrift protocol and nshead protocol (brpc)

2024-04-28 Thread via GitHub
wwbmmm commented on PR #2613: URL: https://github.com/apache/brpc/pull/2613#issuecomment-2081779656 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Fix incorrect core file in run_tests.sh (brpc)

2024-04-28 Thread via GitHub
wwbmmm merged PR #2614: URL: https://github.com/apache/brpc/pull/2614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

[PR] Fix FlatMap assign operator bug (brpc)

2024-04-28 Thread via GitHub
chenBright opened a new pull request, #2622: URL: https://github.com/apache/brpc/pull/2622 ### What problem does this PR solve? Issue Number: Problem Summary: ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响):

Re: [PR] Support connect on socket create (brpc)

2024-04-28 Thread via GitHub
chenBright commented on PR #2574: URL: https://github.com/apache/brpc/pull/2574#issuecomment-2081509018 解决与master的冲突 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [I] brpc可以支持预连接吗 (brpc)

2024-04-28 Thread via GitHub
chenBright commented on issue #2617: URL: https://github.com/apache/brpc/issues/2617#issuecomment-2081357642 > 做成可选项,使用者自己决定 嗯,肯定是做成可选项的。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [I] brpc可以支持预连接吗 (brpc)

2024-04-28 Thread via GitHub
chenBright commented on issue #2617: URL: https://github.com/apache/brpc/issues/2617#issuecomment-2081357281 > 这个说法我有点疑惑,init后马上调用rpc,也需要先创建链接的,他是创建一个链接就马上发,还是等所有链接创建完再发?

Re: [I] brpc可以支持预连接吗 (brpc)

2024-04-28 Thread via GitHub
chenBright commented on issue #2617: URL: https://github.com/apache/brpc/issues/2617#issuecomment-2081356767 目前Socket不支持预先建连,不过 #2574 实现了在创建Socket对象的时候建连。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] brpc可以支持预连接吗 (brpc)

2024-04-28 Thread via GitHub
yzq-del commented on issue #2617: URL: https://github.com/apache/brpc/issues/2617#issuecomment-2081354197 > 不可行吧。 > > 有些时候,channel是动态创建的,Init之后发起rpc。A->B->C这种场景下,B要等到所有socket建连好才发rpc给C,rpc完成后相应A。这时候第一次调用的耗时会显著增加,甚至会超时吧。 这个也不冲突吧。实现的细节问题, -- This is an automated message from