Re: [PR] remove old rpcz directory even if program crash (brpc)

2024-05-26 Thread via GitHub
yanglimingcn commented on PR #2610: URL: https://github.com/apache/brpc/pull/2610#issuecomment-2132556055 @wwbmmm 这个PR还有问题吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-26 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1615404666 ## src/bthread/key.cpp: ## @@ -234,11 +234,12 @@ class KeyTableList { }; static KeyTable* borrow_keytable(bthread_keytable_pool_t* pool) { -if (pool != NULL &&

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-26 Thread via GitHub
chenBright commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1615404058 ## src/bthread/key.cpp: ## @@ -226,14 +267,15 @@ void return_keytable(bthread_keytable_pool_t* pool, KeyTable* kt) { delete kt; return; } -

(brpc) branch master updated: Opt performance of async log (#2602)

2024-05-26 Thread wwbmmm
This is an automated email from the ASF dual-hosted git repository. wwbmmm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new bdc141c9 Opt performance of async log (#2602)

Re: [PR] Opt performance of async log (brpc)

2024-05-26 Thread via GitHub
wwbmmm merged PR #2602: URL: https://github.com/apache/brpc/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [PR] Use butil::ThreadLocal to store keytable (brpc)

2024-05-26 Thread via GitHub
MJY-HUST commented on code in PR #2645: URL: https://github.com/apache/brpc/pull/2645#discussion_r1613198305 ## src/bthread/key.cpp: ## @@ -204,14 +205,54 @@ class BAIDU_CACHELINE_ALIGNMENT KeyTable { SubKeyTable* _subs[KEY_1STLEVEL_SIZE]; }; +class KeyTableList {

Oncall report from May.19th to May.26th

2024-05-26 Thread Jiashun Zhu
Hi, all During the last week, one issue was closed and the following one PR was merged. * Add virtual destructors to MongoServiceAdaptor and SpanFilter #2651 ( https://github.com/apache/brpc/pull/2651) Best,

Re: [PR] circuit breaker with half open state (brpc)

2024-05-26 Thread via GitHub
j05070415 commented on PR #2634: URL: https://github.com/apache/brpc/pull/2634#issuecomment-2132281391 谢谢,您的邮件我已收到! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] circuit breaker with half open state (brpc)

2024-05-26 Thread via GitHub
zyearn commented on code in PR #2634: URL: https://github.com/apache/brpc/pull/2634#discussion_r1615262683 ## src/brpc/circuit_breaker.cpp: ## @@ -45,6 +46,10 @@ DEFINE_int32(circuit_breaker_max_isolation_duration_ms, 3, "Maximum isolation duration in milliseconds");

(brpc) branch master updated: Add virtual destructors to MongoServiceAdaptor and SpanFilter (#2651)

2024-05-26 Thread jiashunzhu
This is an automated email from the ASF dual-hosted git repository. jiashunzhu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new f81af914 Add virtual destructors to

Re: [PR] Add virtual destructors to MongoServiceAdaptor and SpanFilter (brpc)

2024-05-26 Thread via GitHub
zyearn merged PR #2651: URL: https://github.com/apache/brpc/pull/2651 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org