Re: [I] Support arena allocation for server mode in native protocol (brpc)

2024-07-11 Thread via GitHub
chenBright commented on issue #2671: URL: https://github.com/apache/brpc/issues/2671#issuecomment-2224310444 Maybe we can change `ProtobufMessage` to `RpcMessages`, and `ProtobufMessageManager` to `RpcMessageManager`, which are only used for rpc. This would make more sense. -- This is an

Re: [I] Support arena allocation for server mode in native protocol (brpc)

2024-07-11 Thread via GitHub
oathdruid commented on issue #2671: URL: https://github.com/apache/brpc/issues/2671#issuecomment-2224302485 Yes, that's what I said a little weird but useful one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] Support arena allocation for server mode in native protocol (brpc)

2024-07-11 Thread via GitHub
chenBright commented on issue #2671: URL: https://github.com/apache/brpc/issues/2671#issuecomment-2224299335 ```c++ struct ProtobufMessage { google::protobuf::Message* request{NULL}; google::protobuf::Message* response{NULL}; }; class ProtobufMessageManager { pub

Re: [I] Support arena allocation for server mode in native protocol (brpc)

2024-07-11 Thread via GitHub
oathdruid commented on issue #2671: URL: https://github.com/apache/brpc/issues/2671#issuecomment-2224275781 Single ProtobufMessageManager is shared between concurrent rpcs. So two concurrent rpc may invoke their get request and get response interleaved. But without some identifier, Pr

(brpc) branch release-1.10 updated (81ae605d -> 8b5571fd)

2024-07-11 Thread xiaofeng
This is an automated email from the ASF dual-hosted git repository. xiaofeng pushed a change to branch release-1.10 in repository https://gitbox.apache.org/repos/asf/brpc.git from 81ae605d Merge pull request #2610 from yanglimingcn/bugfix/remove_old_rpcz_directory add 9c387c0e fix bug:

[I] brpc AddService 添加的服务实例之间的关系 (brpc)

2024-07-11 Thread via GitHub
yaocunhao opened a new issue, #2690: URL: https://github.com/apache/brpc/issues/2690 **Is your feature request related to a problem? (你需要的功能是否与某个问题有关?)** 全局注册一个唯一的server后, 通过server.AddService 将服务器里面添加服务实例,有如下几个疑问请求解答 **Describe the solution you'd like (描述你期望的解决方法)**

(brpc) branch master updated: Fix multi FlatMap scale and size (#2669)

2024-07-11 Thread xiaofeng
This is an automated email from the ASF dual-hosted git repository. xiaofeng pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/brpc.git The following commit(s) were added to refs/heads/master by this push: new 8b5571fd Fix multi FlatMap scale and size (#2669

Re: [PR] Fix multi FlatMap scale and size (brpc)

2024-07-11 Thread via GitHub
wasphin merged PR #2669: URL: https://github.com/apache/brpc/pull/2669 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org