[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-908047409 @zyearn 你的评论我回复了。看下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907769033 @zyearn 有空看下，CI也过了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907718904 @zyearn 再看下 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907659557 @zyearn 再看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907637593 @zyearn 改成_service_name了，也取消了协议的判断。另外给 src/brpc/details/http_message.cpp 中从uri.host()给Header补Host字段的逻辑，加上了补port。 因为我这个逻辑走到这里，uri.port()还是 -1 不会被 追加到Host字段中（H

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907601489 已经根据反馈修改了代码。有几个地方和你确认一下。 1. Init用命名服务初始化的重载函数中，我还是判断了HTTP协议，因为如果是`file://` 或者`consul://` ，那么参数中的ns_url进行ParseHostname无意义。在InitSingle中没有判断协议了。 2. 当前的实现如果初始化的URL

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-907301176 @zyearn 修改了，但是CI的UT测试不稳定。在我没涉及的地方出问题，而且每次不一样。。 -- This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-905427750 @zyearn 请问看了吗 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-902351786 > 嗯感谢反馈，这两天我们看一下 嗯嗯，Apache有个VirtualHost的功能，就是让一个端口，根据域名路由到不同服务 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-901791978 @jamesge @zyearn 辛苦看看 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-brpc] guodongxiaren commented on pull request #1529: Set hostname rather than ip when channel Init by hostname but not host in http_requst().uri()

guodongxiaren commented on pull request #1529: URL: https://github.com/apache/incubator-brpc/pull/1529#issuecomment-899665692 @zyearn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi