[GitHub] [incubator-brpc] jamesge commented on a change in pull request #537: customise span exporter

jamesge commented on a change in pull request #537: customise span exporter URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695272 ## File path: src/brpc/span.cpp ## @@ -199,47 +199,42 @@ void Span::destroy() { Span* p = _next_client; while (

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #537: customise span exporter

jamesge commented on a change in pull request #537: customise span exporter URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695096 ## File path: src/brpc/span.cpp ## @@ -199,47 +199,42 @@ void Span::destroy() { Span* p = _next_client; while (

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #537: customise span exporter

jamesge commented on a change in pull request #537: customise span exporter URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695570 ## File path: src/brpc/span.cpp ## @@ -304,499 +298,44 @@ void AnnotateSpan(const char* fmt, ...) { va_end(ap); }

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #537: customise span exporter

jamesge commented on a change in pull request #537: customise span exporter URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362695221 ## File path: src/brpc/span.cpp ## @@ -199,47 +199,42 @@ void Span::destroy() { Span* p = _next_client; while (

[GitHub] [incubator-brpc] jamesge commented on a change in pull request #537: customise span exporter

jamesge commented on a change in pull request #537: customise span exporter URL: https://github.com/apache/incubator-brpc/pull/537#discussion_r362696392 ## File path: src/brpc/span.cpp ## @@ -422,378 +314,12 @@ void Span::Submit(Span* span, int64_t cpuwide_time_us) { }