[GitHub] [incubator-brpc] thorneliu commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file

thorneliu commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1312952075 correction merged 3f8e1cc4e23d36094d0a631a499f89f5ad2c4fb4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-brpc] thorneliu commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file

thorneliu commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1296090851 > Is it possible that we fix the host field after a server has been selected? > > > B: set host field by remote_side > > If schema is not http(s), but protocol

[GitHub] [incubator-brpc] thorneliu commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file

thorneliu commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1279650446 > > We could > > > > * A: check if service name a valid host for HTTP > > * B: set host field by remote_side > > > > option B would revert some changes [dab

[GitHub] [incubator-brpc] thorneliu commented on issue #1940: Invalid host in HTTP header if setting host via service_name for channel inited by list or file

thorneliu commented on issue #1940: URL: https://github.com/apache/incubator-brpc/issues/1940#issuecomment-1264134906 We could - A: check if service name a valid host for HTTP - B: set host field by remote_side option B would revert some changes dab62e476 by @guodongxiaren -