[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-10 Thread GitBox
wwbmmm commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r943050314 ## docs/cn/mbvar_c++.md: ## @@ -0,0 +1,774 @@ +- [Introduction](#introduction) Review Comment: 可以在bvar_c++.md和bvar.md中添加一个到这里的链接 -- This is an automated

[GitHub] [incubator-brpc] wwbmmm commented on a diff in pull request #1608: Implement multi bvar feature

2022-08-08 Thread GitBox
wwbmmm commented on code in PR #1608: URL: https://github.com/apache/incubator-brpc/pull/1608#discussion_r940831991 ## src/bvar/multi_dimension_inl.h: ## @@ -0,0 +1,376 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements.