[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270268975 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r270268750 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,233 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-28 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269896275 ## File path: src/brpc/details/health_check.cpp ## @@ -0,0 +1,246 @@ +// Copyright (c) 2014 Baidu, Inc. +// +// Licensed

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-27 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r269507489 ## File path: src/brpc/socket.cpp ## @@ -881,7 +861,7 @@ int Socket::SetFailed(int error_code, const char* error_fmt, ..

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-26 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268964773 ## File path: docs/cn/client.md ## @@ -242,7 +242,7 @@ locality-aware,优先选择延时低的下游,直到其延时高于其他机 | -

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-24 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268477608 ## File path: src/brpc/socket.cpp ## @@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() { delete this; }

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-23 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268420430 ## File path: src/brpc/socket.cpp ## @@ -1026,6 +1125,9 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-23 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268420430 ## File path: src/brpc/socket.cpp ## @@ -1026,6 +1125,9 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-23 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268419761 ## File path: src/brpc/controller.cpp ## @@ -986,7 +986,8 @@ void Controller::IssueRPC(int64_t start_realtime_us) {

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-23 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268419752 ## File path: src/brpc/socket.cpp ## @@ -979,6 +995,89 @@ void HealthCheckTask::OnDestroyingTask() { delete this; }

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268383593 ## File path: src/brpc/socket.cpp ## @@ -780,6 +793,9 @@ void Socket::Revive() { } else { L

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268381737 ## File path: src/brpc/socket.cpp ## @@ -780,6 +793,9 @@ void Socket::Revive() { } else { L

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268103165 ## File path: src/brpc/socket.cpp ## @@ -780,6 +793,9 @@ void Socket::Revive() { } else { L

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-22 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r268067952 ## File path: src/brpc/channel.cpp ## @@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port, r

[GitHub] [incubator-brpc] zyearn commented on a change in pull request #694: Health check by rpc call

2019-03-20 Thread GitBox
zyearn commented on a change in pull request #694: Health check by rpc call URL: https://github.com/apache/incubator-brpc/pull/694#discussion_r267273523 ## File path: src/brpc/channel.cpp ## @@ -281,6 +281,15 @@ int Channel::Init(butil::EndPoint server_addr_and_port, r