warriorpaw opened a new pull request, #2180:
URL: https://github.com/apache/brpc/pull/2180
OpenSSL does not guarantee that any of its objects can be used concurrently
by multiple threads:
https://github.com/openssl/openssl/issues/2165
https://github.com/openssl/openssl/issues/20446
wwbmmm merged PR #2180:
URL: https://github.com/apache/brpc/pull/2180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
F
wwbmmm commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486094743
Does this affect performance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
jingshi-ant commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486100599
> Does this affect performance?
about 20% slower in my 100w data set test. (mainly because of ssl enable. if
remove lock and enable ssl, the speed is almost the same with lock adde
warriorpaw commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1486138968
> Does this affect performance?
Brpc already piped write requests by linked list and only one bthread calls
ssl_write.
In data reading, brpc use epoll in edge triggered mode
wwbmmm commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1510816717
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
warriorpaw commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1526908464
@jamesge @Huixxi @wwbmmm @chenBright
Please take another look if this change can be merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the mes
chenBright commented on PR #2180:
URL: https://github.com/apache/brpc/pull/2180#issuecomment-1526959370
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
