Re: [PR] Opt performance of async log (brpc)

2024-05-27 Thread via GitHub
chenBright commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2132713933 日志时间应该是跟原来一样的,只影响落盘时间。 https://github.com/apache/brpc/blob/bdc141c9e4f287f3b6e6397e09ea821838d273ee/src/butil/logging.cc#L1308-L1314 -- This is an automated message from the

Re: [PR] Opt performance of async log (brpc)

2024-05-27 Thread via GitHub
wasphin commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2132705346 这里对日志时间的影响是可接收的吗? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Opt performance of async log (brpc)

2024-05-26 Thread via GitHub
wwbmmm merged PR #2602: URL: https://github.com/apache/brpc/pull/2602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

Re: [PR] Opt performance of async log (brpc)

2024-05-24 Thread via GitHub
chenBright commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2129192263 @wwbmmm 这个PR应该可以合了 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Opt performance of async log (brpc)

2024-05-24 Thread via GitHub
Superskyyy commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2128949264 Hi, let's merge this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Opt performance of async log (brpc)

2024-04-21 Thread via GitHub
wwbmmm commented on PR #2602: URL: https://github.com/apache/brpc/pull/2602#issuecomment-2068349462 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Opt performance of async log (brpc)

2024-04-14 Thread via GitHub
chenBright opened a new pull request, #2602: URL: https://github.com/apache/brpc/pull/2602 ### What problem does this PR solve? Issue Number: Problem Summary: ``` thread_num=1 log_type=sync log_size=100 count=462130 duration=2s qps=231065 average_time=4349.05us