[GitHub] [incubator-brpc] JimChengLin commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

JimChengLin commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790766992 ## File path: src/bthread/mutex.h ## @@ -48,15 +48,15 @@ class Mutex { Mutex() { int ec = bthread_mutex_init(&_mutex, NULL);

[GitHub] [incubator-brpc] x2c3z4 commented on a change in pull request #1669: Fix C++ compile issue and clang compile issue

x2c3z4 commented on a change in pull request #1669: URL: https://github.com/apache/incubator-brpc/pull/1669#discussion_r790812822 ## File path: src/bthread/mutex.h ## @@ -48,15 +48,15 @@ class Mutex { Mutex() { int ec = bthread_mutex_init(&_mutex, NULL);

[GitHub] [incubator-brpc] hcoona commented on pull request #1417: add option LINK_GFLAGS

hcoona commented on pull request #1417: URL: https://github.com/apache/incubator-brpc/pull/1417#issuecomment-1020749287 应该只有 glog 用了 gflags，而且 glog 对 gflags 的依赖应该是可选的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th