[jira] [Created] (CALCITE-1353) first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions.

2016-08-21 Thread Francis Chuang (JIRA)
Francis Chuang created CALCITE-1353: --- Summary: first_frame_max_size in an ExecuteRequest should be an int32 in protobuf definitions. Key: CALCITE-1353 URL: https://issues.apache.org/jira/browse/CALCITE-1353

Re: What is the default value of max_rows_total in the avatica server?

2016-08-21 Thread F21
Just opened CALCITE-1352 to track this :) On 22/08/2016 1:34 PM, Josh Elser wrote: Anything <=0 should be treated as "all results" (at least given what I recall from the code comments). Would be good to verify regardless. It's entirely possible that when I introduced the new attribute, I (unne

[jira] [Created] (CALCITE-1352) Clarify documentation for avatica's max_row_totals

2016-08-21 Thread Francis Chuang (JIRA)
Francis Chuang created CALCITE-1352: --- Summary: Clarify documentation for avatica's max_row_totals Key: CALCITE-1352 URL: https://issues.apache.org/jira/browse/CALCITE-1352 Project: Calcite

Re: What is the default value of max_rows_total in the avatica server?

2016-08-21 Thread Josh Elser
Anything <=0 should be treated as "all results" (at least given what I recall from the code comments). Would be good to verify regardless. It's entirely possible that when I introduced the new attribute, I (unnecessarily) changed the previous semantics :) F21 wrote: I tried setting it to -1 a

Re: What is the default value of max_rows_total in the avatica server?

2016-08-21 Thread F21
I tried setting it to -1 and it appears to return unlimited rows. Maybe this is not a bug, but just needs to be better documented? On 22/08/2016 11:59 AM, Josh Elser wrote: Hrm, that sounds like a bug. The default value of '0' and an explicit value of '0' should have the exact same semantics (a

Re: What is the default value of max_rows_total in the avatica server?

2016-08-21 Thread Josh Elser
Hrm, that sounds like a bug. The default value of '0' and an explicit value of '0' should have the exact same semantics (an unlimited number of values for the statement). Mind filing a bug? F21 wrote: Hi Josh, Thanks! That clears things up. I noticed that if I explicitly set max_rows_total t