Re: Reviews please

2018-07-08 Thread Julian Hyde
On Sat, Jul 7, 2018 at 3:56 PM, Michael Mior wrote: > I've done a scan of the code and it looks great to me. Also compiled > and ran tests on my machine just in case. I love commits that delete > more code than they add (over 2,600 deleted lines!) I had no idea I'd net-deleted code. A nice side

Re: Reviews please

2018-07-08 Thread Julian Hyde
On Sun, Jul 8, 2018 at 5:42 AM, Enrico Olivelli wrote: > I am sorry I have not much time to try out the branch and do some of the > implementations on Babel before 1.17 release (which I am assuming it to be > immediate after merging this feature branch) No worries - this is just a start. > Most

Re: Reviews please

2018-07-08 Thread Enrico Olivelli
Il dom 8 lug 2018, 00:57 Michael Mior ha scritto: > I've done a scan of the code and it looks great to me. Also compiled > and ran tests on my machine just in case. I love commits that delete > more code than they add (over 2,600 deleted lines!) I did have a > couple comments that were mostly jus