I have reviewed. See my comments in the jira case.
> On Jul 26, 2018, at 11:22 PM, Stamatis Zampetakis wrote:
>
> Hello,
>
> Can somebody have a look at
> [CALCITE-2404] Accessing structured-types is not implemented by the runtime
> https://issues.apache.org/jira/browse/CALCITE-2404
>
> The
Julian, I have amended the commit message in f0b00f0c
On Mon, Jul 30, 2018 at 4:22 PM Julian Hyde wrote:
> I’m running tests on the PR now.
>
> Since commit comments are a soap-box of mine, I will remark that rather
> than
>
> [CALCITE-2428] Fix cassandra unit test initialization. (Andrei
I’m running tests on the PR now.
Since commit comments are a soap-box of mine, I will remark that rather than
[CALCITE-2428] Fix cassandra unit test initialization. (Andrei Sereda)
the commit comment should be
[CALCITE-2428] Cassandra unit test fails to parse version string (Andrei
Thanks Andrei for digging into this! Since I haven't reproduced this
failure myself, if someone else could check out the PR, that would be
great.
--
Michael Mior
mm...@apache.org
Le lun. 30 juil. 2018 à 13:29, Andrei Sereda a écrit :
> Agree, flaky tests are pretty annoying. I'll try to watch
Vladimir Sitnikov created CALCITE-2430:
--
Summary: AssertionError: RelDataTypeImpl.getFieldList when SQL
Advisor inspects non-struct field
Key: CALCITE-2430
URL:
Vladimir Sitnikov created CALCITE-2429:
--
Summary: NPE: SqlValidatorImpl.lookupFieldNamespace when SQL
Advisor observes non-existing field
Key: CALCITE-2429
URL:
Il dom 29 lug 2018, 19:31 srikanth ha scritto:
> favorite
> <
> https://stackoverflow.com/questions/51547864/apache-calcite-and-sql-parsing?noredirect=1#
> >
>
> I am working on a project that needs to connect to the database to retrieve
> the SQL Statements. Once I retrieved the SQL queries
Agree, flaky tests are pretty annoying. I'll try to watch more carefully
new "embedded data-source" issues (fongo, ES, cassandra). They introduced
more "non-determinism" because they now run as part of regular build which
means executed much more often than IT.
Last commit was for a more
On balance, I don’t think we should back out CassandraAdapterTest. But we do
need to continue working to make it more resilient. Any test that generates too
many false negatives over the long run should be disabled, and this is no
exception.
And as the other test results show, it’s not the
Pls check and confirm that the following PR fixes the issue:
https://github.com/apache/calcite/pull/770
It addresses build failures due to version parsing.
Stale folders / files will be addressed in a different PR.
On Mon, Jul 30, 2018 at 10:10 AM Andrei Sereda wrote:
> This must be something
Andrei Sereda created CALCITE-2428:
--
Summary: cassandra unit test initialization failure
Key: CALCITE-2428
URL: https://issues.apache.org/jira/browse/CALCITE-2428
Project: Calcite
Issue
This must be something specific to Cassandra Unit. Will check
On Mon, Jul 30, 2018, 08:59 Sergey Nuyanzin wrote:
> There is one more strange thing (at least on Windows): while building a
> file with name ".toDelete" is generated under calcite\cassandra and it's
> not removed by the end of tests
There is one more strange thing (at least on Windows): while building a
file with name ".toDelete" is generated under calcite\cassandra and it's
not removed by the end of tests
Is there a way to make cassandra generates these files in target directory
e.g.?
On Mon, Jul 30, 2018 at 3:52 PM,
Most of the problems are during test init Phase. Most likely with version
string (eg. 11-ea for JDK11).
I'll fix that.
On Mon, Jul 30, 2018 at 8:16 AM Michael Mior wrote:
> I tested myself a fair bit under Ubuntu before pushing this and didn't see
> any of these issues myself. That said, I
I tested myself a fair bit under Ubuntu before pushing this and didn't see
any of these issues myself. That said, I agree that it's important the test
suite be stable. I'm fine with reverting for now or (more preferably IMO)
just disabling these tests by default.
--
Michael Mior
mm...@apache.org
15 matches
Mail list logo
