[ANNOUNCE] Apache Calcite Avatica Go 3.1.0 released

2018-09-09 Thread Francis Chuang
The Apache Calcite team is pleased to announce the release of Apache Calcite Avatica Go 3.1.0. Avatica is a framework for building database drivers. Avatica defines a wire API and serialization mechanism for clients to communicate with a server as a proxy to a database. The reference Avatica

Calcite-Master - Build # 820 - Still Failing

2018-09-09 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #820) Status: Still Failing Check console output at https://builds.apache.org/job/Calcite-Master/820/ to view the results.

Re: Commit 88f125541, "Reduce HepPlannerTest#testRuleApplyCount complexity"

2018-09-09 Thread Julian Hyde
The technical justification is that the code — yes, sql is code — that you removed might have found a bug someday. A deep relational algebra tree places stresses on hep planner (and other parts of the system) that we cannot predict. The (implicit) expected behavior is that it doesn’t crash,

Re: Commit 88f125541, "Reduce HepPlannerTest#testRuleApplyCount complexity"

2018-09-09 Thread Vladimir Sitnikov
Julian>You seem to believe that the only purpose of a test is to test the specific bug or change for which it was introduced I'm afraid you seem to put words in my mouth. Note: so far I have technical reasons to keep the test with reduced number of lines while you don't. Note2: original test

Re: Commit 88f125541, "Reduce HepPlannerTest#testRuleApplyCount complexity"

2018-09-09 Thread Julian Hyde
You seem to believe that the only purpose of a test is to test the specific bug or change for which it was introduced. That is indeed the philosophy of test-driven development, but there are more things in heaven and earth than TDD. Calcite is a complex project, and needs complex tests to shake

Re: Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

2018-09-09 Thread Julian Hyde
Kevin, I think we should remove those classes. We may run into compatibility issues in future — or, as in this case, want to use features that are in a version of a library or the JDK that not all of our users are happy to upgrade to — and if so, we can always resurrect the files from git

Re: Commit 88f125541, "Reduce HepPlannerTest#testRuleApplyCount complexity"

2018-09-09 Thread Vladimir Sitnikov
Julian>I strongly disagree with your commit 88f125541. You have removed test code that is useful in creating a high-quality product. Could you please provide technical justification? Note: the test is still there. Note2: the test still runs in both Travis and Apache Jenkins. The test still runs

Commit 88f125541, "Reduce HepPlannerTest#testRuleApplyCount complexity"

2018-09-09 Thread Julian Hyde
Vladimir, I strongly disagree with your commit 88f125541. You have removed test code that is useful in creating a high-quality product. I presume that your goal is to make the test suite run a little faster. I think you should back out your commit. I sent a previous email on the subject but you

Re: Sqlline release

2018-09-09 Thread Michael Mior
Thanks Julian and all others who contributed to this release! -- Michael Mior mm...@apache.org Le dim. 9 sept. 2018 à 10:11, Arina Yelchiyeva a écrit : > Thank you, Julian! > > Kind regards, > Arina > > On Sun, Sep 9, 2018 at 8:20 AM Sergey Nuyanzin > wrote: > > > Thank you very much for

[jira] [Created] (CALCITE-2543) Upgrade SQLLine to 1.5.0

2018-09-09 Thread Julian Hyde (JIRA)
Julian Hyde created CALCITE-2543: Summary: Upgrade SQLLine to 1.5.0 Key: CALCITE-2543 URL: https://issues.apache.org/jira/browse/CALCITE-2543 Project: Calcite Issue Type: Bug

Re: Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

2018-09-09 Thread Vladimir Sitnikov
Kevin>I think that means that both Compatible and CompatibleGuava11 can be removed since they should no longer be used. Could we keep the files as a monument to Guava's version policy? Vladimir

Removing o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11

2018-09-09 Thread Kevin Risden
Based on the comments in the two files (o.a.c.u.Compatible and o.a.c.u.CompatibleGuava11), they were added to ensure that Calcite was compatible with Guava 11 and JDK 1.7. As of Calcite 1.16.0, JDK 1.8 and Guava 19 are minimum requirements. I think that means that both Compatible and

Re: Sqlline release

2018-09-09 Thread Arina Yelchiyeva
Thank you, Julian! Kind regards, Arina On Sun, Sep 9, 2018 at 8:20 AM Sergey Nuyanzin wrote: > Thank you very much for recognition and releasing sqlline > > did several checks on final version: > - Bumped dependency in Apache Calcite and compiled > - Created custom command handler in

[RESULT] [VOTE] Release calcite-avatica-go-3.1.0 (release candidate 2)

2018-09-09 Thread Francis Chuang
Thanks to everyone who has tested the release candidate and given their comments and votes. The tally is as follows. 3 binding +1s: Francis Chuang Josh Elser Julian Hyde Kevin Risden No 0s or -1s. Therefore I am delighted to announce that the proposal to release Apache Calcite Avatica Go