Re: [DISCUSS] Draft board report for January 2019

2019-01-02 Thread Francis Chuang
My apologies, Michael. I like the idea of using labels to categorize the PRs. For instance, something like "xs", "small", "medium", "large" etc to categorize the scope of the change might make it easier for committers to identify easy-to-review PRs. This might be useful for those who are not

Re: [DISCUSS] Draft board report for January 2019

2019-01-02 Thread Michael Mior
Thanks Francis! My last name is spelled Mior, not Moir, but other than that looks good to me. I have no opinion on whether the problem with PRs should be placed under "Issues" so I'll defer to Julian's Apache experience on that. Technical solutions are certainly not going to solve the problem

Re: [DISCUSS] Draft board report for January 2019

2019-01-02 Thread Francis Chuang
Thanks, Julian! I mentioned changing the PMC Chair and the migration to gitbox. I also added a bit about the reviewing of PRs under "issues". I am not quite sure what the board can do to help us, but I do hope this is something we can address soon for Calcite. Avatica and Avatica-Go seem to

Re: Support of Regex in CalciteAssert

2019-01-02 Thread Michael Mior
+1 to what Julian said. -- Michael Mior mm...@apache.org Le mer. 2 janv. 2019 à 19:57, Julian Hyde a écrit : > I wouldn’t do regex by default. Quite a few characters are regex meta > characters (e.g. “(“ and “.”) and it’s a pain to have to remember to escape > them when copy-pasting output

Re: Support of Regex in CalciteAssert

2019-01-02 Thread Julian Hyde
I wouldn’t do regex by default. Quite a few characters are regex meta characters (e.g. “(“ and “.”) and it’s a pain to have to remember to escape them when copy-pasting output into the test. So, my vote is for > .returns(regexMatch("id=\\p{Graph}+; a=1")) // separate consumer I don’t have an

Support of Regex in CalciteAssert

2019-01-02 Thread Andrei Sereda
Hello, As part of [CALCITE-2755](https://issues.apache.org/jira/browse/CALCITE-2755) ([982](https://github.com/apache/calcite/pull/982)) I needed to perform regex comparison of result (since it is not known in advance). The assertion looks like: ```java assertThat() .query("select id, a from

Re: [DISCUSS] Draft board report for January 2019

2019-01-02 Thread Julian Hyde
Even though you probably don’t want to blow your own trumpet, Francis, I think we should call out the change of VP, and the fact that we have had a "peaceful transition of power” to a new person every year since graduation. I am proud of this particular Calcite tradition, and one excellent side

Re: [DISCUSS] Draft board report for January 2019

2019-01-02 Thread Francis Chuang
Thanks Kevin, looks like I forgot the version number (1.13) for Avatica. I'll also move it to a separate paragraph, so that it's more prominent. Francis On 3/01/2019 8:34 am, Kevin Risden wrote: Should call out the Avatica release in the Activity section. Kevin Risden On Wed, Jan 2, 2019 at

[DISCUSS] Draft board report for January 2019

2019-01-02 Thread Francis Chuang
Attached below is a draft of this month's board report. Please let me know if you have any additions or corrections. ## Description: Apache Calcite is a highly customizable framework for parsing and planning queries on data in a wide variety of formats. It allows database-like access, and in

Re: ElasticSearch adapter. Exposing meta fields (like _id, _uid etc.)

2019-01-02 Thread Andrei Sereda
Thanks, Stamatis. I wanted to confirm that adding one more mapping is not redundant (this information might have existed somewhere). I am not sure if you really need to keep the mapping between EXPR and ITEM or just the field names Do you mean having a List instead of a Map ? Currently, I’m