zabetak commented on a change in pull request #1020: [CALCITE-2812] Add
algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1020#discussion_r255021963
##
File path:
core/src/main/java/org/apache/calcite/jdbc/Ca
chadasa opened a new pull request #1036: [CALCITE-2815] GeodeSchemaFactory
change to pass in clientCache using jndi
URL: https://github.com/apache/calcite/pull/1036
CALCITE-2815 GeodeSchemaFactory change to pass in clientCache using geode
jndi context
Addressed previous pull request 102
zabetak commented on a change in pull request #1020: [CALCITE-2812] Add
algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1020#discussion_r255037109
##
File path:
linq4j/src/main/java/org/apache/calcite/linq4
zabetak commented on a change in pull request #1020: [CALCITE-2812] Add
algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1020#discussion_r255034331
##
File path:
core/src/test/java/org/apache/calcite/test/en
zabetak commented on a change in pull request #1020: [CALCITE-2812] Add
algebraic operators to allow expressing recursive queries (Ruben Quesada Lopez)
URL: https://github.com/apache/calcite/pull/1020#discussion_r255022728
##
File path: core/src/main/java/org/apache/calcite/tools/Re
chadasa closed pull request #1036: [CALCITE-2815] GeodeSchemaFactory change to
pass in clientCache using jndi
URL: https://github.com/apache/calcite/pull/1036
This is an automated message from the Apache Git Service.
To resp
chadasa opened a new pull request #1036: [CALCITE-2815] GeodeSchemaFactory
change to pass in clientCache using jndi
URL: https://github.com/apache/calcite/pull/1036
CALCITE-2815 GeodeSchemaFactory change to pass in clientCache using geode
jndi context
Addressed previous pull request 102
stutigupta028 opened a new pull request #1037: Dialect specific operator support
URL: https://github.com/apache/calcite/pull/1037
This is an automated message from the Apache Git Service.
To respond to the message, please log
stutigupta028 closed pull request #1037: Dialect specific operator support
URL: https://github.com/apache/calcite/pull/1037
This is an automated message from the Apache Git Service.
To respond to the message, please log on Gi
jacques-n commented on issue #980: [CALCITE-2736] Update the
ReduceExpressionsRule to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461892376
@vlsi, sorry I didn't respond sooner, got caught up in some other things.
I agree with avoidance of boole
jacques-n commented on issue #980: [CALCITE-2736] Update the
ReduceExpressionsRule to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461893076
> @jacques-n , I don't understand why do you have multiple JIRA/PRs for the
same code changes. If 973 is irrele
vlsi commented on issue #980: [CALCITE-2736] Update the ReduceExpressionsRule
to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461897840
>Another option is using builder-esque pattern with an options object. I
chose the second option because it benefits
The Travis build has been broken for 3 cycles:
https://travis-ci.org/apache/calcite/builds
It occurs on the JDK11 JDOC=Y build, and started happening with
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=21fe666e9634ab9a752c7cc328924b68f6143afe.
Vladimir, can you please take a loo
The Apache Jenkins build system has built Calcite-Master (build #1016)
Status: Failure
Check console output at https://builds.apache.org/job/Calcite-Master/1016/ to
view the results.
Julian> Vladimir, can you please take a look?
As you see, the commit did not touch "Calcite Plus", so I don't really
think the commit is to blame here. It looks more like JDK-8212233 to
me.
On top of that, Calcite Plus does not build on my machine (see
CALCITE-2816 PsTableFunction fails in Russian
Does someone else have time to take a look?
> On Feb 8, 2019, at 11:17 AM, Vladimir Sitnikov
> wrote:
>
> Julian> Vladimir, can you please take a look?
>
> As you see, the commit did not touch "Calcite Plus", so I don't really
> think the commit is to blame here. It looks more like JDK-821223
Hi,
I understand... If we are overriding the calcite's cost function in
adapter, then should we also generate cost as record? And how does calcite
compare the costs of different nodes in different convention? And how
calcite generate the cheapest plan? Is there any algorithm dedicated for
that? I
I can take a look. I poked around a bit yesterday and saw the same thing
about the commit not changing javadocs. Not sure if JDK 11 got updated to
have this issue. I'll see what it takes to fix.
Kevin Risden
On Fri, Feb 8, 2019 at 2:30 PM Julian Hyde wrote:
> Does someone else have time to tak
>From the two builds:
- Working - Java version: 11.0.1, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
- Failed - Java version: 11.0.2, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-11-openjdk-amd64
Testing with this locally to see how this reproduces
>And how does calcite
> compare the costs of different nodes in different convention?
Lekshmi, please check RelOptCost interface.
https://github.com/apache/calcite/blob/9721283bd0ce46a337f51a3691585cca8003e399/core/src/main/java/org/apache/calcite/plan/RelOptCost.java#L68-L91
Adaptor implementati
The Apache Jenkins build system has built Calcite-Master (build #1017)
Status: Still Failing
Check console output at https://builds.apache.org/job/Calcite-Master/1017/ to
view the results.
risdenk opened a new pull request #1038: Fix javadoc
URL: https://github.com/apache/calcite/pull/1038
Testing to see if this fixes javadoc.
This is an automated message from the Apache Git Service.
To respond to the message,
risdenk commented on issue #1038: Fix javadoc
URL: https://github.com/apache/calcite/pull/1038#issuecomment-461934770
Build is going to fail since I cancelled JDK 9, 10, 12 since don't care if
they pass just looking at the JDK 8/11 javadoc build.
---
Looks like this might just be a leftover compiler plugin in calcite-plus
module.
https://github.com/apache/calcite/pull/1038
The PR above passes with a minor change of removing the compiler-plugin to
use the top level pom defined one. The comment is out of date as well.
I'll open a ticket for th
Kevin Risden created CALCITE-2836:
-
Summary: Remove maven-compiler-plugin from calcite-plus module
pom.xml
Key: CALCITE-2836
URL: https://issues.apache.org/jira/browse/CALCITE-2836
Project: Calcite
risdenk closed pull request #1038: Fix javadoc
URL: https://github.com/apache/calcite/pull/1038
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above t
risdenk opened a new pull request #1039: [CALCITE-2836] Remove
maven-compiler-plugin from calcite-plus module pom.xml
URL: https://github.com/apache/calcite/pull/1039
This is an automated message from the Apache Git Service.
https://issues.apache.org/jira/browse/CALCITE-2836
Kevin Risden
On Fri, Feb 8, 2019 at 3:41 PM Kevin Risden wrote:
> Looks like this might just be a leftover compiler plugin in calcite-plus
> module.
>
> https://github.com/apache/calcite/pull/1038
>
> The PR above passes with a minor change of
risdenk closed pull request #1039: [CALCITE-2836] Remove maven-compiler-plugin
from calcite-plus module pom.xml
URL: https://github.com/apache/calcite/pull/1039
This is an automated message from the Apache Git Service.
To re
jacques-n edited a comment on issue #980: [CALCITE-2736] Update the
ReduceExpressionsRule to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461950331
> Those options do not invalidate each other. Even builder benefits from
enum types.
We'll have t
jacques-n commented on issue #980: [CALCITE-2736] Update the
ReduceExpressionsRule to better expose options
URL: https://github.com/apache/calcite/pull/980#issuecomment-461950331
> Those options do not invalidate each other. Even builder benefits from
enum types.
We'll have to agree
Master is backed to fixed after committing CALCITE-2836
https://travis-ci.org/apache/calcite/builds/490737420
Kevin Risden
On Fri, Feb 8, 2019 at 3:47 PM Kevin Risden wrote:
> https://issues.apache.org/jira/browse/CALCITE-2836
>
> Kevin Risden
>
>
> On Fri, Feb 8, 2019 at 3:41 PM Kevin Risden
The Apache Jenkins build system has built Calcite-Master (build #1018)
Status: Still Failing
Check console output at https://builds.apache.org/job/Calcite-Master/1018/ to
view the results.
Thanks Kevin!
--
Michael Mior
mm...@apache.org
Le ven. 8 févr. 2019 à 16:48, Kevin Risden a écrit :
>
> Master is backed to fixed after committing CALCITE-2836
>
> https://travis-ci.org/apache/calcite/builds/490737420
>
> Kevin Risden
>
>
> On Fri, Feb 8, 2019 at 3:47 PM Kevin Risden wrote:
>
>
Cost is always a record in Calcite, so yes. Costs from different
conventions are compared directly. It's assumed that all the costs are
expressed in a way they can be correctly compared. Again, this is not
ideal, but it's what we have now and it works relatively well. The
planner finds the cheapest
Thanks for taking this on, Kevin, and solving it so efficiently. I really
appreciate it.
https://issues.apache.org/jira/browse/CALCITE-2339 was blocked by this issue
(its PR was giving CI errors) and is now unblocked.
Julian
> On Feb 8, 2019, at 3:30 PM, Michael Mior wrote:
>
> Thanks Kevin
In retrospect, I think it was a mistake to make cost a record. Of course we
would like to represent different aspects of cost (cpu, io, number of bytes
moved, amount of memory used) but the optimization algorithm has trouble if the
cost function does not have a total order (i.e. c1 <= c3 if and
37 matches
Mail list logo
