Re: "ASF GitHub Bot added a worklog" emails

Julian>I’m getting a dozen or so such emails each day. It seems that one bot is adding a work log I do get those though I have just a few of them somehow. Francis> I do get a lot of emails via the list for Github comments, reviews and Francis> PRs and I am somewhat questioning the utility of

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466288322 hi @zhztheplayer I'm on the train. I'll deal with this at night. Thank you for your understanding. best qianjin

[GitHub] zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466271735 @XuQianJin-Stars Could you please solve the conflicts and squash your commits into a single commit?

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466263911 hi @zhztheplayer Thank you very much. I have added `JSON_TYPE`into the non-reserved keyword according to your help. best

Re: "ASF GitHub Bot added a worklog" emails

I am not getting these, I suspect that the emails might be due to your JIRA settings or the fact that you're assigned to those issues. I do get a lot of emails via the list for Github comments, reviews and PRs and I am somewhat questioning the utility of those emails. On 22/02/2019 12:04 pm,

[GitHub] zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-466253345 @XuQianJin-Stars, following is details about how you can make `JSON_TYPE` non-reserved: 1. Add `JSON_TYPE` to list

[GitHub] XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259195950 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259193931 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259192979 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r259192155 ## File path: site/_docs/reference.md ## @@ -1992,6 +1993,29 @@ Note: | value IS JSON ARRAY

[GitHub] XuQianJin-Stars edited a comment on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars edited a comment on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-465945517 hi @zhztheplayer I have addressed all comments. Can you continue to review? best qianjin

[GitHub] godfreyhe commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public

godfreyhe commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1050#issuecomment-466240468 thanks for your suggestion @michaelmior This is an automated

Re: Schema constructors and direct dependencies (vs JNDI)

If you really want to pass in an object, I suggest to pass in a URI string and then the adapter code can use some kind of directory service (e.g. JNDI) to get the object. But then how do I retrieve that directory service from Schema (hope not a static variable) ? Don’t you couple a schema to a

"ASF GitHub Bot added a worklog" emails

Are other people getting emails saying "ASF GitHub Bot added a worklog on CALCITE-”? It seems to have started recently. I’m getting a dozen or so such emails each day. It seems that one bot is adding a work log (e.g. “Time spent: 10m”) and another bot is sending an email reporting what the

[GitHub] michaelmior merged pull request #1049: CALCITE-2856-Emulating Cross Join For SparkSqlDialect

michaelmior merged pull request #1049: CALCITE-2856-Emulating Cross Join For SparkSqlDialect URL: https://github.com/apache/calcite/pull/1049 This is an automated message from the Apache Git Service. To respond to the

[GitHub] michaelmior commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public

michaelmior commented on issue #1050: [CALCITE-2855] Make RelOptCluster constructor public URL: https://github.com/apache/calcite/pull/1050#issuecomment-466229817 @godfreyhe In the future, no need to create a new PR. Just change the commit and force push to the same branch and the PR will

[GitHub] michaelmior commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

michaelmior commented on a change in pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058#discussion_r259177109 ## File path: core/src/main/java/org/apache/calcite/plan/volcano/VolcanoPlanner.java

Re: Schema constructors and direct dependencies (vs JNDI)

The original motivation for only allowing serializable parameters was to allow queries to be run in a different JVM than the one in which they were prepared. (Remember, in enumerable convention, a prepared query is a generated java class.) (By serializable I mean JSON types: primitives, lists

Re: Calcite Avatica - JIRA version cleanup?

Kevin, I'm guessing you're right that this should be cleaned up. I've added you as an admin to the Calcite JIRA project so you should be able to make changes yourself. -- Michael Mior mm...@apache.org Le sam. 9 févr. 2019 à 09:45, Kevin Risden a écrit : > > I was looking at JIRA and noticed

Re: Schema constructors and direct dependencies (vs JNDI)

SchemaFactory already imposes “serializable” objects using the following interface : Schema create( SchemaPlus parentSchema, String name, Map operand); operand parameter is taken from configuration

Re: joins and low selectivity optimization

Hi Stamatis, As usual, appreciate your time to answer my questions. I will try to give more context below. I am not I understand why bloom-filters and block based nested loop are not possible for your use case Our destination data-source (ElasticSearch / Mongo) doesn’t support filtering based

[GitHub] jh3507 opened a new pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

jh3507 opened a new pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058 By default, cost for Convention.NONE is infinity. - Add option to allow Convention.None planning with VolcanoPlanner - Add a unit

[jira] [Created] (CALCITE-2860) Recognize materialized views based on Aggregate

Julian Hyde created CALCITE-2860: Summary: Recognize materialized views based on Aggregate Key: CALCITE-2860 URL: https://issues.apache.org/jira/browse/CALCITE-2860 Project: Calcite Issue

[GitHub] jcamachor commented on issue #1056: CALCITE-2858

jcamachor commented on issue #1056: CALCITE-2858 URL: https://github.com/apache/calcite/pull/1056#issuecomment-466158989 Last commit fixes an issue with nested types (ClassCastException) and changes the visibility of a few fields to protected.

support more UDFs

Hello! I would like to help with task https://issues.apache.org/jira/browse/CALCITE-1733. Please assign it to me, my jira account is isengor. Ilia Gorelikhin Junior Software Engineer Office: +7 812 611 10 94 x 30454 Cell: +7 931 257 91 89 Email:

[GitHub] jcamachor commented on a change in pull request #1056: CALCITE-2858

jcamachor commented on a change in pull request #1056: CALCITE-2858 URL: https://github.com/apache/calcite/pull/1056#discussion_r259028672 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -391,13 +385,17 @@ RexNode toRex(RelInput

[jira] [Created] (CALCITE-2859) Centralize Calcite system properties

Stamatis Zampetakis created CALCITE-2859: Summary: Centralize Calcite system properties Key: CALCITE-2859 URL: https://issues.apache.org/jira/browse/CALCITE-2859 Project: Calcite

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258932425 ## File path:

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258932425 ## File path:

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258930923 ## File path:

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258930853 ## File path:

Re: Calcite-Master - Build # 1027 - Still Failing

I've performed multiple builds, and it looks like Java8 is still suffering from misunderoptimization :( https://builds.apache.org/job/Calcite-Master/1029/ https://builds.apache.org/job/Calcite-Master/1031/ Vladimir

Calcite-Master - Build # 1031 - Failure

The Apache Jenkins build system has built Calcite-Master (build #1031) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Master/1031/ to view the results.

Calcite-Master - Build # 1029 - Failure

The Apache Jenkins build system has built Calcite-Master (build #1029) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Master/1029/ to view the results.

[GitHub] zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

zabetak commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258886000 ## File path:

Re: Calcite-Master - Build # 1027 - Still Failing

It may be a combination of those. However the test highlighted in my previous email is a typical manifestation of FilterProjectTransposeRule that does not always simplify the new filter condition. I just merged CALCITE-2582. Let's and see how it goes. Στις Τετ, 20 Φεβ 2019 στις 11:33 π.μ., ο/η

[GitHub] zabetak merged pull request #847: [CALCITE-2582] FilterProjectTransposeRule does not always simplify the new filter condition (Stamatis Zampetakis)

zabetak merged pull request #847: [CALCITE-2582] FilterProjectTransposeRule does not always simplify the new filter condition (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/847 This is an automated

[GitHub] kgyrtkirk commented on a change in pull request #1056: CALCITE-2858

kgyrtkirk commented on a change in pull request #1056: CALCITE-2858 URL: https://github.com/apache/calcite/pull/1056#discussion_r258865526 ## File path: core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java ## @@ -391,13 +385,17 @@ RexNode toRex(RelInput

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-465945517 hi @zhztheplayer I have addressed all comments. best qianjin

[GitHub] XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r258860096 ## File path: site/_docs/reference.md ## @@ -2002,14 +2002,14 @@ Note: Example Data: ```JSON

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r258857345 ## File path: site/_docs/reference.md ## @@ -2002,14 +2002,14 @@ Note: Example Data: ```JSON

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r258857345 ## File path: site/_docs/reference.md ## @@ -2002,14 +2002,14 @@ Note: Example Data: ```JSON

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258820630 ## File path:

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r258857345 ## File path: site/_docs/reference.md ## @@ -2002,14 +2002,14 @@ Note: Example Data: ```JSON

[GitHub] zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function

zhztheplayer commented on a change in pull request #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#discussion_r258856936 ## File path: site/_docs/reference.md ## @@ -2002,14 +2002,14 @@ Note: Example Data: ```JSON

[GitHub] yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

yuqi1129 commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r258830720 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

vlsi commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r258829490 ## File path: core/src/test/java/org/apache/calcite/test/JdbcTest.java ## @@

[GitHub] XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function

XuQianJin-Stars commented on issue #1013: [CALCITE-2791]Add the JSON_TYPE function URL: https://github.com/apache/calcite/pull/1013#issuecomment-465907686 hi @zhztheplayer I have revised this PR. I hope you can spare your precious time to review it best qianjin

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258820630 ## File path:

[GitHub] yuqi1129 opened a new pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

yuqi1129 opened a new pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057 …mal type operands This is an automated message from the

[GitHub] rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez)

rubenada commented on a change in pull request #898: [CALCITE-2464] Allow to set nullability for columns of structured types (Ruben Quesada Lopez) URL: https://github.com/apache/calcite/pull/898#discussion_r258820630 ## File path: