Re: About ElasticsearchToEnumerableConverterRule

2019-03-12 Thread Yuzhao Chen
Yeah, did you replace the Convention trait of the matched node when matches ? Best, Danny Chan 在 2019年3月12日 +0800 PM8:59,Jocean shi ,写道: > I sure this ConverterRule matches. In other world, this method has excuted. > but the final result is only root RelNode has been replaced. > > > Best >

Re: Integration Test failures - JdbcTest and JdbcAdapterTest

2019-03-12 Thread Kevin Risden
Stamatis - Thanks for looking into this! I'm not sure the integration test against postgres has been run recently. I went back to branch-1.18 and get the AbstractMethodError errors identified here: CALCITE-2732 - Upgrade postgresql driver version. CALCITE-2732 didn't upgrade the Postgres driver

[jira] [Created] (CALCITE-2918) Integration tests against postgres are broken

2019-03-12 Thread Kevin Risden (JIRA)
Kevin Risden created CALCITE-2918: - Summary: Integration tests against postgres are broken Key: CALCITE-2918 URL: https://issues.apache.org/jira/browse/CALCITE-2918 Project: Calcite Issue

Re: Integration Test failures - JdbcTest and JdbcAdapterTest

2019-03-12 Thread Stamatis Zampetakis
My understanding so far regarding the first problem. The query plan is the following: JdbcToEnumerableConverter JdbcFilter(condition=[AND(OR(IS NOT NULL($3), IS NOT NULL($3)), IS NOT TRUE(=($3, $3)))]) JdbcTableScan(table=[[foodmart, employee]]) and the SQL query which is send to Postgres

Calcite-Master - Build # 1073 - Failure

2019-03-12 Thread Apache Jenkins Server
The Apache Jenkins build system has built Calcite-Master (build #1073) Status: Failure Check console output at https://builds.apache.org/job/Calcite-Master/1073/ to view the results.

[jira] [Created] (CALCITE-2917) Calcite should use double quote as default identifier delimiter

2019-03-12 Thread Nan Deng (JIRA)
Nan Deng created CALCITE-2917: - Summary: Calcite should use double quote as default identifier delimiter Key: CALCITE-2917 URL: https://issues.apache.org/jira/browse/CALCITE-2917 Project: Calcite

[jira] [Created] (CALCITE-2916) Upgrade jackson to 2.9.8

2019-03-12 Thread Kevin Risden (JIRA)
Kevin Risden created CALCITE-2916: - Summary: Upgrade jackson to 2.9.8 Key: CALCITE-2916 URL: https://issues.apache.org/jira/browse/CALCITE-2916 Project: Calcite Issue Type: Bug

Re: RelToSqlConverter support for EnumerableLimit

2019-03-12 Thread Stamatis Zampetakis
Hi Anupam, After the merge of Calcite-2827 [1] to master, it is possible to get as an ouput of the volcano planner a logical plan. Maybe using this new feature you can use the MV substitution without introducing physical operators. Best, Stamatis [1]

Re: Integration Test failures - JdbcTest and JdbcAdapterTest

2019-03-12 Thread Stamatis Zampetakis
If I find some time, I will try to look this evening. Στις Τρί, 12 Μαρ 2019 στις 4:26 μ.μ., ο/η Kevin Risden έγραψε: > Bump - Any ideas on the postgres failure? > > Kevin Risden > > > On Mon, Mar 11, 2019 at 11:51 AM Kevin Risden wrote: > > > It looks like there are 2 failures so far when

Re: Integration Test failures - JdbcTest and JdbcAdapterTest

2019-03-12 Thread Kevin Risden
Bump - Any ideas on the postgres failure? Kevin Risden On Mon, Mar 11, 2019 at 11:51 AM Kevin Risden wrote: > It looks like there are 2 failures so far when running the integration > tests ( > https://calcite.apache.org/docs/howto.html#running-integration-tests) > > 1. I'm not sure about the

Re: About ElasticsearchToEnumerableConverterRule

2019-03-12 Thread Jocean shi
I sure this ConverterRule matches. In other world, this method has excuted. but the final result is only root RelNode has been replaced. Best Jocean.shi

Re: RelToSqlConverter support for EnumerableLimit

2019-03-12 Thread Anupam Aggarwal
Thanks Julian. I am using VolcanoPlanner to do the MV rewrite, to get an optimised relNode (and then convert to Sql) (wasn't able to get the HepPlanner do the MV substitution using a logical plan) Logged a JIRA (will open a PR shortly)

[jira] [Created] (CALCITE-2915) Add RelToSqlConverter support for EnumerableLimit

2019-03-12 Thread Anupam Aggarwal (JIRA)
Anupam Aggarwal created CALCITE-2915: Summary: Add RelToSqlConverter support for EnumerableLimit Key: CALCITE-2915 URL: https://issues.apache.org/jira/browse/CALCITE-2915 Project: Calcite

Re: About ElasticsearchToEnumerableConverterRule

2019-03-12 Thread Yuzhao Chen
The ConverterRule is a RelOptRule but with default implementation of onMatch: public void onMatch(RelOptRuleCall call) { RelNode rel = call.rel(0); if (rel.getTraitSet().contains(inTrait)) { final RelNode converted = convert(rel); if (converted != null) { call.transformTo(converted);

Re: About ElasticsearchToEnumerableConverterRule

2019-03-12 Thread Jocean shi
I use Volcano. Is it cost that rule do not happen? Best Jocean.shi Yuzhao Chen 于2019年3月12日周二 上午10:26写道: > Then what kind of Planner you use, if it is Volcano it is not expected to > happen. > > Best, > Yuzhao Chen > 在 2019年3月11日 +0800 PM11:08,Jocean shi ,写道: > > Thanks for your help. > > I get