Sorry about that, I will cancel the vote and start a new one for rc1 ASAP.
In the meantime, do we want to fix CALCITE-2816 (or skip the relevant tests
for problematic locales)?
On Thu, Sep 5, 2019 at 8:28 AM Julian Feinauer
wrote:
> Hi,
>
> I took the freedom to fork a DISCUSS thread to keep th
Julian, thanks so much for providing the reference and the historical note.
I have no strong objections for the table hints format you proposed, overall,
the grammar look more unified and concise.
Also many thanks for the suggestions of the code.
Best,
Danny Chan
在 2019年9月5日 +0800 AM10:43，Julia
Hey,
I'm not sure if we need to cancel it ASAP, I would wait for the results of
Julian (Hyde) and Danny and their binding votes.
As every PMC handles that a bit differently I'm unsure whether you consider
that "major enough" or not.
Julian
Am 05.09.19, 09:19 schrieb "Stamatis Zampetakis" :
The vote for apache-calcite-1.21.0 release candidate 0, is cancelled due to
redundant/unwanted files (pom.xml.next, pom.xml.tag) in the binaries.
On Thu, Sep 5, 2019 at 8:04 AM Danny Chan wrote:
> I made the diff cmd and also see these outputs, it seems that pom.xml.next
> and pom.xml.tag comes
I think we should not include these .xml.xxx files into the jar. Also the
.gitignore file be included.
Best,
Danny Chan
在 2019年9月5日 +0800 PM3:23，Julian Feinauer ，写道：
> Hey,
>
> I'm not sure if we need to cancel it ASAP, I would wait for the results of
> Julian (Hyde) and Danny and their binding
Frankly speaking I would refrain from adding `table WITH ...`
It is not clear if you allow to add hints at subquery level. I think we
should allow that.
For instance, https://github.com/ossc-db/pg_hint_plan allows top-level
hints only, and that is really hard to use when SQL is build dynamically.
Despite the cancelation, I carried on my diligence.
-0 (binding) due to the spurious .xml.xxx files.
Everything else was OK: I checked checked hashes, README, NOTICE, LICENSE,
built and tested on JDK 11/Ubuntu, ran RAT.
If there is another release, I would like to include some low-impact PRs. I
Hi all,
I came across this JIRA and am not sure what its status is. The original
proposal in the bug looks reasonable to me. We currently propagate importance
improvement through a depth-first model, which could result in stack overflow
if the memo is very big and very deep. Change it into a br
Mehdi Salarkia created CALCITE-3325:
---
Summary: Thread Local Buffer Variable (threadLocalBuffer) In
ProtobufTranslationImpl Is Defined As Non Static Causing Memory Leak
Key: CALCITE-3325
URL: https://issues.apach
Julian, I have merged these PRs.
https://github.com/apache/calcite/pull/1435: merged
https://github.com/apache/calcite/pull/1438: merged and mark fixed at version
1.21
https://github.com/apache/calcite/pull/1431: merged
Best,
Danny Chan
在 2019年9月6日 +0800 AM4:35，dev@calcite.apache.org，写道：
>
> htt
Darn it. I had already started on this, and put in a couple of hours
of work cleaning things up.
I've pushed my changes anyway, to my branch
https://github.com/julianhyde/calcite/tree/branch-1.21. I also made
some copy edits to the release notes. Stamatis can cherry-pick it all
into the official b
> I removed the "[hotfix]" and "[doc]" tags from the commit messages. I
> don't think we need to create our own "tag language" in commit
> messages.
I agree, thanks.
Best,
Danny Chan
在 2019年9月6日 +0800 PM12:55，dev@calcite.apache.org，写道：
>
> I removed the "[hotfix]" and "[doc]" tags from the commit
I see. I think you are directing to using STRING for the table and
descriptor parameters.
If so I think it's a good idea to do prototyping. I am digging into
implementation to prototype a version of "TABLE(TUMBLE("table_name",
"column_name", INTERVAL))" now.
-Rui
On Wed, Sep 4, 2019 at 8:03 PM
The vote for Apache Calcite 1.21.0 release candidate 0 was cancelled due to
spurious .xml.xxx files in the binaries
Thanks to all who voted. A new release will be tagged as 1.21.0-rc1 and
will be available for voting soon.
Best,
Stamatis
14 matches
Mail list logo
