Re: [DISCUSS] Should RexSimplify retain the order of the predicates or not

2020-03-15 Thread Chunwei Lei
Thanks for sharing your thoughts, Julian and Michael. Now I understand more about the design. Best, Chunwei On Sat, Mar 7, 2020 at 1:51 AM Julian Hyde wrote: > Sorry, I didn’t explain the example very well. Should have said “assume a > random() function that returns the same value each time

Re: [DISCUSS] Code reviews

2020-03-15 Thread Chunwei Lei
Thanks for your effort, Stamatis. I totally agree that breaking and other significant changes should be reviewed and receive +1 before committing. Regarding the minimum wait time to commit, I think 72 hours might be too long. Maybe 24-48 hours is enough. Best, Chunwei On Sun, Mar 15, 2020 at

[jira] [Created] (CALCITE-3862) Rewriting for materialized view consisting of group by on join keys with aggregate fails

2020-03-15 Thread Vineet Garg (Jira)
Vineet Garg created CALCITE-3862: Summary: Rewriting for materialized view consisting of group by on join keys with aggregate fails Key: CALCITE-3862 URL: https://issues.apache.org/jira/browse/CALCITE-3862

TableModify does not keep UPSERT keyword

2020-03-15 Thread Enrico Olivelli
Hi, I am trying to use UPSERT but it seems to me that in TableModify (or best LogicalTableModify or EnumerableTableModify) there is no way to distinguish an INSERT from an UPSERT. Am I missing something? Regards Enrico