Thanks to everyone who has tested the release candidate and given
their comments and votes.
The tally is as follows.
5 binding +1s:
Haisheng, Francis, Danny, Julian Hyde, Laurent
5 non-binding +1s:
Anton, Enrico, Feng Zhu, Xing Jin, Forward Xu
1 non-binding +0s:
Ruben Q L
Therefore I am
My intent was not to cause sadness, sorry about that.
I should have elaborated a bit more why I don't think Github is that much
of an issue:
- LICENSE file at the root of the project is the source of truth, not
Github mention. It is a nice to have the correct license for Github for
sure, but it
Laurent>As for Github, I think this is a non-issue
I have provided an example: https://github.com/embox/embox
It is an example when GitHub fails to detect the license.
It is really sad to hear that "you think it is a non-issue" even in case
you have seen the failure case.
Laurent>on the source
Vote: +1 (binding)
- Local Calcite builds (./gradlew clean build && ./gradlew testSlow) on
MacOS and JDK8/11/14: OK
- tarball content and signature: OK
On Fri, May 15, 2020 at 9:02 PM Haisheng Yuan wrote:
> Hi all,
>
> I have created a build for Apache Calcite 1.23.0, release
> candidate 1.
>
I meant the source distribution here.
I guess I didn't realize Calcite source tree has embedded copies of some
3rd party css/js, but since those are not fetched dynamically and are part
of the source tree, I think the committed LICENCE file should include those
vs altering it at release time. As
My keys are signed by Stamatis, thanks for helping, Stamatis!
Now the keys link worked,
https://people.apache.org/keys/committer/hyuan.asc
No more action is needed, Julian.
Thanks,
Haisheng
On 2020/05/22 00:25:15, Julian Hyde wrote:
> OK, I imported Haisheng's key from KEYS and now it
Laurent> I'm slightly confused. Are any of MIT dependencies mentioned in
LICENSE
Laurent> bundled with the distribution?
Which distribution do you mean?
Of course, Calcite source release bundles third-party dependencies (e.g.
site/js/*.js files).
Vladimir
I'm slightly confused. Are any of MIT dependencies mentioned in LICENSE
bundled with the distribution?
On Fri, May 22, 2020 at 12:45 AM Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
> Julian>It does not need to happen before
> Julian>the release, but before we announce.
>
>
Julian>It does not need to happen before
Julian>the release, but before we announce.
Cross-signing is not required at all.
Julian>All files should match those in the source repo at that
Julian>precise commit.
Julian> Could this version of LICENSE be the committed one?
Long story short: LICENSE
