Re: [DISCUSS] Fixing things that aren't broken

2020-09-05 Thread Vladimir Sitnikov
Hey Julian, I can imagine it might be unexpected (and/or fearful) to see that many issues / changes out of a blue. I do not expect that you rush into review right away (or even spent your time on that!). However, I do value your feedback, and it is indeed helpful. No jokes, it was helpful, and I

Re: [DISCUSS] Fixing things that aren't broken

2020-09-05 Thread Julian Hyde
And let’s add https://issues.apache.org/jira/browse/CALCITE-4217 to the list of changes that Vladimir has committed despite my clear objections. > On Sep 5, 2020, at 3:43 PM, Julian Hyde wrote: > > In the Apache Way, how do I say, ‘Please

[DISCUSS] Fixing things that aren't broken

2020-09-05 Thread Julian Hyde
In the Apache Way, how do I say, ‘Please stop trying to fix this. It isn’t broken.’ Vladimir has been trying to fix things that aren’t broken over the last week. It has been driving me crazy. It has wasted a bunch of my time, answering his questions, pointing out that the behavior is intended.

[jira] [Created] (CALCITE-4231) org.apache.calcite.rex.RexProgram.Marshaller might need overriding visitSubQuery / visitTableInputRef / visitPatternFieldRef

2020-09-05 Thread Vladimir Sitnikov (Jira)
Vladimir Sitnikov created CALCITE-4231: -- Summary: org.apache.calcite.rex.RexProgram.Marshaller might need overriding visitSubQuery / visitTableInputRef / visitPatternFieldRef Key: CALCITE-4231 URL: