Hey Julian, thank you for rolling search/sarg expression. I believe it is a valuable feature.
Unfortunately, the new feature causes noticeable regressions, and it looks like the regressions are still there :( I believe the major cause of regressions is missing tests for the added feature :( Note: the tests were there before Sarg, however, when you add a new RexNode, you need to teach RexInterpreter to deal with it. Currently, RexProgramFuzzyTest ignores Sarg expressions, and it could have prevented the regressions. You should have missed my ask to add tests (see https://github.com/apache/calcite/pull/2233#issuecomment-720113993 ), so would you please re-add the test coverage (RexInterpreter, RexAnalyzer, RexProgramFuzzyTest) for Sarg and fix the issues? Vladimir
