Re: INSERT Query Question

2021-10-02 Thread Charles Givre
Hi Julian, Thanks for your response. I created CALCITE-4820 (https://issues.apache.org/jira/browse/CALCITE-4820 ) to address this. With that said, do you think there's a configuration setting somewhere that I missed that removes the ROW

[jira] [Created] (CALCITE-4820) INSERT Queries have keyword ROW inserted VALUES

2021-10-02 Thread Charles Givre (Jira)
Charles Givre created CALCITE-4820: -- Summary: INSERT Queries have keyword ROW inserted VALUES Key: CALCITE-4820 URL: https://issues.apache.org/jira/browse/CALCITE-4820 Project: Calcite

Re: [DISCUSS] Add extra check for Avatica to run tests with different timezone

2021-10-02 Thread Stamatis Zampetakis
Hi all, I like the idea of extending our test coverage and the fact people are putting effort on this topic. I don't really mind having randomized or fixed CI checks as long as: 1. it doesn't break too often due to the environment; 2. it is capable to pinpoint regressions/problems on specific

Re: [DISCUSS] Add extra check for Avatica to run tests with different timezone

2021-10-02 Thread Vladimir Sitnikov
>I don’t think we should do randomized CI Then please incorporate: a) Testing with "-XX:+UnlockExperimentalVMOptions -XX:hashCode=2" to ensure the code does not rely on Object#hashCode uniqueness b) different OSes c) Different JDK vendors, versions and JIT implementations (e.g. OpenJ9, Microsoft,

Re: [DISCUSS] Add extra check for Avatica to run tests with different timezone

2021-10-02 Thread Julian Hyde
I don’t think we should do randomized CI. > On Oct 2, 2021, at 1:32 PM, Vladimir Sitnikov > wrote: > > Here's a randomized matrix for Avatica: > https://github.com/apache/calcite-avatica/pull/156 > https://github.com/apache/calcite-avatica/actions/runs/1298777387 > > Vladimir

Re: [DISCUSS] Add extra check for Avatica to run tests with different timezone

2021-10-02 Thread Vladimir Sitnikov
Here's a randomized matrix for Avatica: https://github.com/apache/calcite-avatica/pull/156 https://github.com/apache/calcite-avatica/actions/runs/1298777387 Vladimir

Re: [DISCUSS] Syntax upgrade about Session Window Table Function

2021-10-02 Thread Viliam Durina
Btw, the table argument, according to the sql standard, must be in parentheses, like this: SELECT * FROM TABLE(SESSION(TABLE(input_table), ... When doing a breaking change, we should also consider this. Viliam On Thu, 30 Sept 2021 at 18:11, Julian Hyde wrote: > Thanks for the examples. The

Re: [DISCUSS] Add extra check for Avatica to run tests with different timezone

2021-10-02 Thread Vladimir Sitnikov
I suggest to settle on the number of CI jobs we can afford to keep the CI duration sane, and we generate a random sample. The number of CI jobs might be different for PR builds and for branch builds. We have many different interesting timezones, many Guava versions, only 3 OS, many JDKs for each