Review Request: PR for ISSUE-5000

2022-02-16 Thread 徐仁和
Hi community, Anyone could help to review the pr. ISSUE: https://issues.apache.org/jira/browse/CALCITE-5000 PR: https://github.com/apache/calcite/pull/2714 This Jira aims to reduce aggregate functions, when arg of agg-call is in the aggregate's group. Example: -- origin sql select max(c1) from

Re: Identifier starting with number parse fail

2022-02-16 Thread Julian Hyde
+1 Babel is an appropriate place to support this. (It would not be practical to implement in parser config, because tokenization needs to be efficient. It is better done in a separate parser, which is what Babel has.) XuRenhe, Please log a feature request in Jira to support MySQL-style

Re: Identifier starting with number parse fail

2022-02-16 Thread xiong duan
I do some search in: PostgreSQL: https://www.postgresql.org/docs/9.1/sql-syntax-lexical.html > don't support SqlServer: https://docs.microsoft.com/en-us/sql/relational-databases/databases/database-identifiers?view=sql-server-ver15 >don't support Oracle:

Re: Identifier starting with number parse fail

2022-02-16 Thread Ruben Q L
Hello XuRenhe, Please be aware that our dev list does not allow images. Regarding your question, I found this on the SQL standard: « An is any character in the Unicode General Category classes “Lu”, “Ll”, “Lt”, “Lm”, “Lo”, or “Nl”. NOTE 95 — The Unicode General Category classes “Lu”, “Ll”,

Identifier starting with number parse fail

2022-02-16 Thread 徐仁和
Hi community: Parsing sql fails, when meeting the identifier starting with number. Here, test case: // org.apache.calcite.test.SqlToRelConverterTest @Test void testIdentifierStartWithNumber() { final String sql = "select 1_c1 from (select deptno as 1_c1 from emp)"; sql(sql).ok(); } It