Re: [VOTE] Release Apache Calcite Avatica 1.23.0 (release candidate 0)

2023-01-15 Thread Francis Chuang
Thanks for being RM for this release, Julian! My vote is: +1 (binding) - Verified GPG signature - OK - Verified SHA512 - OK - Diffed source release and git repository - OK - Checked release notes on tag (https://github.com/apache/calcite-avatica/blob/avatica-1.23.0-rc0/site/_docs/history.md) -

[VOTE] Release Apache Calcite Avatica 1.23.0 (release candidate 0)

2023-01-15 Thread Julian Hyde
Hi all, I have created a build for Apache Calcite Avatica 1.23.0, release candidate 0. Thanks to everyone who has contributed to this release. You can read the release notes here: https://github.com/apache/calcite-avatica/blob/avatica-1.23.0-rc0/site/_docs/history.md The commit to be voted upon

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-15 Thread Benchao Li
Thanks Francis for the pointer, it works! Then I guess the right url should be: https://sonarcloud.io/project/overview?id=apache_calcite This one works for me. Francis Chuang 于2023年1月16日周一 04:46写道: > Hey Benchao, > > I also see that issue when trying to log in via > https://sonarcloud.io/projec

Re: [DISCUSS] Towards Calcite-Avatica 1.23.0

2023-01-15 Thread Francis Chuang
+1 Great idea, Julian! Avatica is way overdue for a release. On 16/01/2023 7:08 am, Julian Hyde wrote: I'm thinking of making a quick release of Avatica, so that Calcite 1.33 (which is alleged [1] to be happening soon) can be based on Avatica 1.23. (Avatica 1.22 was six months ago, and there hav

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-15 Thread Francis Chuang
Hey Benchao, I also see that issue when trying to log in via https://sonarcloud.io/project/roles?id=apache_calcite. The solution is to log in here: https://sonarcloud.io/login, go to the Apache organization and then go to the calcite project. Francis On 16/01/2023 12:36 am, Benchao Li wrote

Re: [DISCUSS] Towards Calcite 1.33.0

2023-01-15 Thread Julian Hyde
I have created a jira case to track this release: https://issues.apache.org/jira/browse/CALCITE-5481 Also, I am proposing to make a quick Avatica 1.23 release. If the plans work out, it will be ready for inclusion in Calcite 1.33 from Thursday. Julian On 2023/01/05 20:21:03 Julian Hyde wrote:

[DISCUSS] Towards Calcite-Avatica 1.23.0

2023-01-15 Thread Julian Hyde
I'm thinking of making a quick release of Avatica, so that Calcite 1.33 (which is alleged [1] to be happening soon) can be based on Avatica 1.23. (Avatica 1.22 was six months ago, and there have been about 20 bug fixes since then.) The following PRs seem ready to merge: * https://github.com/apach

[jira] [Created] (CALCITE-5481) Release Calcite 1.33.0

2023-01-15 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5481: Summary: Release Calcite 1.33.0 Key: CALCITE-5481 URL: https://issues.apache.org/jira/browse/CALCITE-5481 Project: Calcite Issue Type: Bug Report

[jira] [Created] (CALCITE-5480) Release Avatica 1.23.0

2023-01-15 Thread Julian Hyde (Jira)
Julian Hyde created CALCITE-5480: Summary: Release Avatica 1.23.0 Key: CALCITE-5480 URL: https://issues.apache.org/jira/browse/CALCITE-5480 Project: Calcite Issue Type: Bug Componen

Re: [DISCUSS] Code quality/coverage with SonarCloud & JaCoCo

2023-01-15 Thread Benchao Li
When I open this url[1], it tells me that "You are not authorized to access this page". Is this expected? (I'm using my Github account) [1] https://sonarcloud.io/project/roles?id=apache_calcite Alessandro Solimando 于2023年1月13日周五 18:51写道: > Thank you Stamatis for working on this, I see no need t

Re: Why we cannot get all predicates for outer join query?

2023-01-15 Thread Benchao Li
Hi Jiajun, For outer join, the semantic is different for predicates in condition and where, for example: Q1: select * from emp left join dept on emp.deptno = dept.deptno Q2: select * from emp left join dept on true where emp.deptno = dept.deptno The semantic is different for Q1 and Q2. Q1 will ou