Re: Calcite RelStructuredTypeFlattener produces bad plan for single field structs in 1.23+

2023-03-02 Thread Andrew Pilloud
: > > Can you please log this? It might be useful if you create a PR with a single > commit to represent the test case. > > We can discuss workarounds or fixes in the jira case. > > > On Mar 2, 2023, at 11:44 AM, Andrew Pilloud > > wrote: > > > > A

[jira] [Created] (CALCITE-5553) Calcite RelStructuredTypeFlattener produces bad plan for single field structs

2023-03-02 Thread Andrew Pilloud (Jira)
Andrew Pilloud created CALCITE-5553: --- Summary: Calcite RelStructuredTypeFlattener produces bad plan for single field structs Key: CALCITE-5553 URL: https://issues.apache.org/jira/browse/CALCITE-5553

Calcite RelStructuredTypeFlattener produces bad plan for single field structs in 1.23+

2023-03-02 Thread Andrew Pilloud
e53ab9781ca2f8e5fdf1cd600317a01819557701 Mon Sep 17 00:00:00 2001 From: Andrew Pilloud Date: Wed, 1 Mar 2023 16:23:39 -0800 Subject: [PATCH] Demonstrate the wrong plan SqlToRelConverterTest > executionError FAILED java.lang.IllegalArgumentException: Actual and reference files differ. If you are adding new tests, repl

Output column names of Calc discarded by VolcanoPlanner in Calcite 2.22+

2023-02-02 Thread Andrew Pilloud
A Beam SQL user found an issue where we are discarding their output field names that appears to be related to a change to the VolcanoPlanner to treat rel nodes that only differ by field names as equivalent:

Re: Substrait, a new project focused on serialized algebra

2021-09-08 Thread Andrew Pilloud
It looks like this project is just you at the moment? I don't see any pull requests or a mailing list. (I'm not on slack.) This seems like something that would be beneficial if you can get other projects to buy into it. [0] How did you agree to the four indicator implementations? Are those

[jira] [Created] (CALCITE-4759) JoinPushThroughJoinRule does not match two joins

2021-08-30 Thread Andrew Pilloud (Jira)
Andrew Pilloud created CALCITE-4759: --- Summary: JoinPushThroughJoinRule does not match two joins Key: CALCITE-4759 URL: https://issues.apache.org/jira/browse/CALCITE-4759 Project: Calcite

[jira] [Created] (CALCITE-3714) BitString.createFromBytes reverses order of the bits in each byte

2020-01-06 Thread Andrew Pilloud (Jira)
Andrew Pilloud created CALCITE-3714: --- Summary: BitString.createFromBytes reverses order of the bits in each byte Key: CALCITE-3714 URL: https://issues.apache.org/jira/browse/CALCITE-3714 Project

Re: Community and News pages "not secure", according to Chrome

2019-10-07 Thread Andrew Pilloud
You can debug this through the developer tools console. In the Chrome menu bar, More tools -> Developer tools. The error message is "Mixed Content: The page at '' was loaded over HTTPS, but requested an insecure image ''. This content should also be served over HTTPS." It appears the github

Re: [VOTE] Release apache-calcite-avatica-1.15.0 (release candidate 0)

2019-05-09 Thread Andrew Pilloud
+1 Tested with Apache Beam, all tests pass. Also tested error messages with SqlLine, SQL Workbench/J, and SQuirreL SQL. Thanks for the quick turnaround! Andrew *From: *Francis Chuang *Date: *Thu, May 9, 2019 at 2:35 AM *To: * Hi all, > > I have created a build for Apache Calcite Avatica

Re: Google BigQuery - zetasql parser/analyzer

2019-05-02 Thread Andrew Pilloud
lConformance to enable various SQL compatibility > >> modes, > >> but it's not enough to solve all the problems. > >> Except sql parsing, different sql engines also have differences on > >> type inferring, > >> type checking and implicit casti

[jira] [Created] (CALCITE-3040) Avatica drops exception messages starting in 1.14.0

2019-04-30 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-3040: --- Summary: Avatica drops exception messages starting in 1.14.0 Key: CALCITE-3040 URL: https://issues.apache.org/jira/browse/CALCITE-3040 Project: Calcite

Re: Google BigQuery - zetasql parser/analyzer

2019-04-25 Thread Andrew Pilloud
I was intending to send an email about this, thanks for starting the discussion. I'm on the team at Google that is open sourcing ZetaSQL. It is a C++ SQL parser used internally for the BigQuery standard sql parser, among other things. We've open source the Java frontend and Rui currently working

[jira] [Created] (CALCITE-2783) Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase.

2019-01-10 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2783: --- Summary: Null checks incorrectly optimized by RexSimplfy.simplifyBooleanCase. Key: CALCITE-2783 URL: https://issues.apache.org/jira/browse/CALCITE-2783 Project

Re: [VOTE] Release apache-calcite-1.18.0 (release candidate 0)

2018-12-05 Thread Andrew Pilloud
+1 (non-binding) - Upgraded Beam, all tests pass against staged artifacts. https://github.com/apache/beam/pull/7209/files - Tested with Beam moved to Calcite's EnumerableCalc codegen, all tests pass against staged artifacts. Thanks for getting this release out! This unblocks a huge code

[jira] [Created] (CALCITE-2710) Some SqlFunctions use LOCAL_TZ constant instead of using timeZone()

2018-11-26 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2710: --- Summary: Some SqlFunctions use LOCAL_TZ constant instead of using timeZone() Key: CALCITE-2710 URL: https://issues.apache.org/jira/browse/CALCITE-2710 Project

Re: [DISCUSS] Towards Calcite 1.18

2018-09-20 Thread Andrew Pilloud
Beam has a few JIRAs we'd like to see make the next release (which will enable us to replace 11k lines of code with calls to Calcite). They all have open PRs. * https://issues.apache.org/jira/browse/CALCITE-2404 Accessing structured-types is not implemented by the runtime *

[jira] [Created] (CALCITE-2572) Calcite substring fails with a start position less than 1.

2018-09-19 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2572: --- Summary: Calcite substring fails with a start position less than 1. Key: CALCITE-2572 URL: https://issues.apache.org/jira/browse/CALCITE-2572 Project: Calcite

[jira] [Created] (CALCITE-2571) TRIM does not match the behavior of most SQL implementations

2018-09-19 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2571: --- Summary: TRIM does not match the behavior of most SQL implementations Key: CALCITE-2571 URL: https://issues.apache.org/jira/browse/CALCITE-2571 Project

Re: VARCHAR literals

2018-09-13 Thread Andrew Pilloud
Just ran into CALCITE-2321 in Beam, this is something we would be interested in as well. Andrew On Tue, Sep 11, 2018 at 7:47 AM Piotr Nowojski wrote: > Thanks! We will look into it. If we decide to go this path we will create > a JIRA ticket for this. > > Piotrek > > > On 10 Sep 2018, at

Re: [DISCUSS] reasonable duration for tests in the Calcite codebase

2018-09-10 Thread Andrew Pilloud
I would expect acceptable test run time to be somewhat bimodal: maximum around 100ms for unit tests (which should be the majority of tests) and minutes for functional and integration tests. It would be good for Travis to run all these tests on every PR, but it would be nice if I could limit my

[jira] [Created] (CALCITE-2529) linq4j should promote integer to floating point when generating function calls

2018-09-04 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2529: --- Summary: linq4j should promote integer to floating point when generating function calls Key: CALCITE-2529 URL: https://issues.apache.org/jira/browse/CALCITE-2529

Re: Site branch merge

2018-07-20 Thread Andrew Pilloud
git log --simplify-merges is probably what you are looking for. Merges are a important tool in busy public repos. On Fri, Jul 20, 2018 at 2:49 PM Michael Mior wrote: I'm fine with that. I can always reset and do a force push. -- Michael Mior mm...@apache.org Le ven. 20 juil. 2018 à 14:38,

Re: [VOTE] Release apache-calcite-1.17.0 (release candidate 0)

2018-07-18 Thread Andrew Pilloud
+1 Updated Apache Beam and ran our integration tests. Everything passed except our UnnestCrossJoin test. (The test fails to plan due to Beam SQL's incomplete implementation of the Correlate rule, there doesn't appear to be a bug in Calcite.) On Tue, Jul 17, 2018 at 6:55 AM Kevin Risden wrote:

[jira] [Created] (CALCITE-2353) Allow user to override SqlSetOption in alterStatementParserMethods

2018-06-05 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2353: --- Summary: Allow user to override SqlSetOption in alterStatementParserMethods Key: CALCITE-2353 URL: https://issues.apache.org/jira/browse/CALCITE-2353 Project

Re: CalcitePrepare inconsistantly applies parser config

2018-05-14 Thread Andrew Pilloud
gt; work. If you can find some small ways to make them more consistent (e.g. > using the same config) that would be helpful. > > Julian > > > > On May 14, 2018, at 11:41 AM, Andrew Pilloud <apill...@google.com.INVALID> > wrote: > > > > I've noticed that the Calci

CalcitePrepare inconsistantly applies parser config

2018-05-14 Thread Andrew Pilloud
I've noticed that the CalcitePrepare interface creates a parser in both the parse and prepare paths, but only the prepare path applies the custom parser config from the context. Is this intentional? Shouldn't both paths use the config from the context? Andrew

[jira] [Created] (CALCITE-2248) Take advantage of Calcite DDL

2018-04-10 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2248: --- Summary: Take advantage of Calcite DDL Key: CALCITE-2248 URL: https://issues.apache.org/jira/browse/CALCITE-2248 Project: Calcite Issue Type: New

Re: Supporting named row construction in Calcite SQL

2018-04-05 Thread Andrew Pilloud
As a user of Calcite working on adding streaming SQL to Apache Beam this sounds like a fantastic proposal. Our initial goal is to be able to run SQL queries that transform arbitrary JSON objects. Without this syntax objects must be flattened when they pass through the transform. Is this something

[jira] [Created] (CALCITE-2177) TUMBLE_START does not respect AS when SELECT and GROUP BY match

2018-02-14 Thread Andrew Pilloud (JIRA)
Andrew Pilloud created CALCITE-2177: --- Summary: TUMBLE_START does not respect AS when SELECT and GROUP BY match Key: CALCITE-2177 URL: https://issues.apache.org/jira/browse/CALCITE-2177 Project