[GitHub] siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0

siddharthteotia commented on issue #1033: [CALCITE-2820] Add a version of AggregateReduceFunctionsRule that does not reduce SUM to SUM0 URL: https://github.com/apache/calcite/pull/1033#issuecomment-468497873 ping @vlsi , @julianhyde, @laurentgo

[GitHub] jcamachor opened a new pull request #1079: [CALCITE-2883] HepPlanner subprogram may loop till getting out of memory

jcamachor opened a new pull request #1079: [CALCITE-2883] HepPlanner subprogram may loop till getting out of memory URL: https://github.com/apache/calcite/pull/1079 This is an automated message from the Apache Git Service.

[GitHub] hsyuan commented on issue #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

hsyuan commented on issue #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#issuecomment-468496263 @julianhyde I have addressed your comments, thanks for the review. Can you take another

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261428663 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261429146 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261430620 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261429313 ## File path:

[GitHub] julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

julianhyde commented on a change in pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078#discussion_r261430446 ## File path:

[GitHub] hsyuan opened a new pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable

hsyuan opened a new pull request #1078: [CALCITE-896] Remove Aggregate if grouping columns are unique and all functions are splittable URL: https://github.com/apache/calcite/pull/1078 JIRA: https://issues.apache.org/jira/browse/CALCITE-896

[GitHub] risdenk commented on issue #811: Add LGTM code quality badges

risdenk commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468472598 Closing this PR due to no immediate need to move forward. If LGTM and Apache legal due to Github permissions end up working together we can look at this

[GitHub] risdenk closed pull request #811: Add LGTM code quality badges

risdenk closed pull request #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] julianhyde commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand

julianhyde commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand URL: https://github.com/apache/calcite/pull/784#issuecomment-468468357 +1 but please change the commit message; remove the word 'fix' and describe the actual problem being fixed.

[GitHub] julianhyde commented on issue #811: Add LGTM code quality badges

julianhyde commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468467926 I'm -0 on this. Doesn't seem to be worth the effort. The PR submitter works for the company, so we would be free advertising for them. But our

[GitHub] risdenk commented on issue #811: Add LGTM code quality badges

risdenk commented on issue #811: Add LGTM code quality badges URL: https://github.com/apache/calcite/pull/811#issuecomment-468460341 Not sure how I feel about this one. Based on https://issues.apache.org/jira/browse/INFRA-17226 LGTM can't be integrated with the build. Since INFRA is

[GitHub] risdenk closed pull request #998: Suggestion: Improvement of Autoboxing and Unboxing

risdenk closed pull request #998: Suggestion: Improvement of Autoboxing and Unboxing URL: https://github.com/apache/calcite/pull/998 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] risdenk commented on issue #998: Suggestion: Improvement of Autoboxing and Unboxing

risdenk commented on issue #998: Suggestion: Improvement of Autoboxing and Unboxing URL: https://github.com/apache/calcite/pull/998#issuecomment-468459175 Closing since there is no JIRA attached to this PR and only addresses a single line. As @vlsi pointed out, there isn't a big reason to

[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468458376 Where do you get MultiJoins in the first place?

[GitHub] vlsi commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand

vlsi commented on issue #784: [CALCITE-2456] fix VolcanoRuleCall#match for unordered child operand URL: https://github.com/apache/calcite/pull/784#issuecomment-468457409 Yes it is good and committable. This is an automated

[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468449888 @vlsi ... we use this initially only to get some random ordering (not possibly the

[GitHub] julianhyde commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261393964 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on a change in pull request #1031: [CALCITE-2742]: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261386852 ## File path:

[GitHub] siddharthteotia commented on issue #1029: [CALCITE-2824] Fix invalid usage of RexExecutorImpl

siddharthteotia commented on issue #1029: [CALCITE-2824] Fix invalid usage of RexExecutorImpl URL: https://github.com/apache/calcite/pull/1029#issuecomment-468441305 @vlsi , @laurentgo , I am not sure how exactly we can test test this. The code change here avoids the direct casing of

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378619 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378419 ## File path:

[GitHub] siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r261378248 ## File path:

[GitHub] asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi

asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi URL: https://github.com/apache/calcite/pull/1036#issuecomment-468429549 If we go JNDI route (see [dev

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1036 should be merged depending on result of discussion on

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1036 should be merged depending on result of discussion on

[GitHub] asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

asereda-gs edited a comment on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1022 should be merged depending on result of discussion on

[GitHub] julianhyde commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

julianhyde commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261350210 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] hsyuan opened a new pull request #1077: [CALCITE-2818] EXTRACT returns wrong results for DATE and TIMESTAMP values before epoch

hsyuan opened a new pull request #1077: [CALCITE-2818] EXTRACT returns wrong results for DATE and TIMESTAMP values before epoch URL: https://github.com/apache/calcite/pull/1077 JIRA: https://issues.apache.org/jira/browse/CALCITE-2818

[GitHub] kgyrtkirk opened a new pull request #1076: [CALCITE-2421] Generalize simplification of self-comparisions

kgyrtkirk opened a new pull request #1076: [CALCITE-2421] Generalize simplification of self-comparisions URL: https://github.com/apache/calcite/pull/1076 This change enables to rewrite comparisions between the same operands to a form which relys on the nullability check of the original

[GitHub] zabetak merged pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis)

zabetak merged pull request #950: [CALCITE-2703] Reduce code generation and class loading overhead when executing queries in the EnumerableConvention (Stamatis Zampetakis) URL: https://github.com/apache/calcite/pull/950

[GitHub] zhztheplayer closed pull request #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

zhztheplayer closed pull request #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897 This is an automated message from the Apache Git Service. To

[GitHub] zhztheplayer edited a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

zhztheplayer edited a comment on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly for now, closing temporarily.

[GitHub] zhztheplayer commented on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent…

zhztheplayer commented on issue #897: [CALCITE-2648] Output collation of EnumerableWindow is not consistent… URL: https://github.com/apache/calcite/pull/897#issuecomment-468301076 I have no cue to solve the problem perfectly, closing temporarily.

[GitHub] zhztheplayer closed pull request #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi…

zhztheplayer closed pull request #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi… URL: https://github.com/apache/calcite/pull/984 This is an automated message from the Apache Git Service. To

[GitHub] zhztheplayer commented on issue #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi…

zhztheplayer commented on issue #984: [CALCITE-2593] Sometimes fails to plan when a RelNode transform multi… URL: https://github.com/apache/calcite/pull/984#issuecomment-468300249 Going to close this PR -- let's wait for coming into consensus in JIRA.

[GitHub] zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to

[GitHub] zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer edited a comment on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to

[GitHub] zhztheplayer commented on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer commented on issue #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#issuecomment-468292958 @yuqi1129 I've added some comments to the PR. Besides, please link your commit's email address to you

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261217611 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261215687 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261213916 ## File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java

[GitHub] zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci…

zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code gen error for UNARY_MINUS operator call with deci… URL: https://github.com/apache/calcite/pull/1057#discussion_r261213393 ## File path:

[GitHub] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468268420 > Hi @XuQianJin-Stars, could you please address Michael's comment? By looking into MySQL's JSON_LENGTH spec[1], I also think it's no

[GitHub] zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468267253 Hi @XuQianJin-Stars, could you please address Michael's comment? By looking into MySQL's JSON_LENGTH spec[1], I also think it's no need

[GitHub] zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

zhztheplayer commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468251438 @XuQianJin-Stars Sorry for the delaying, will take a look soon. This

[GitHub] zabetak commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

zabetak commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261139530 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@

[GitHub] XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function

XuQianJin-Stars commented on issue #1070: [CALCITE-2808]Add the JSON_LENGTH function URL: https://github.com/apache/calcite/pull/1070#issuecomment-468221805 hi @michaelmior @zhztheplayer Thank you very much. I hope that you can take the time to review this PR. best qianjin

[GitHub] vlsi commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties

vlsi commented on a change in pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059#discussion_r261129603 ## File path: core/src/main/java/org/apache/calcite/config/CalciteSystemProperty.java ## @@ -0,0

[GitHub] zabetak merged pull request #1059: [CALCITE-2859] Centralize Calcite system properties

zabetak merged pull request #1059: [CALCITE-2859] Centralize Calcite system properties URL: https://github.com/apache/calcite/pull/1059 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] ritesh-kapoor opened a new pull request #1075: CALCITE-2881: Adding JSON_PRETTY function support

ritesh-kapoor opened a new pull request #1075: CALCITE-2881: Adding JSON_PRETTY function support URL: https://github.com/apache/calcite/pull/1075 This is an automated message from the Apache Git Service. To respond to the

[GitHub] kgyrtkirk commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative

kgyrtkirk commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative URL: https://github.com/apache/calcite/pull/1073#discussion_r261072973 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1652,7

[GitHub] asereda-gs closed pull request #1074: WIP: [CALCITE-2457] JUnit5 migration

asereda-gs closed pull request #1074: WIP: [CALCITE-2457] JUnit5 migration URL: https://github.com/apache/calcite/pull/1074 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] asereda-gs opened a new pull request #1074: WIP: [CALCITE-2457] JUnit5 migration

asereda-gs opened a new pull request #1074: WIP: [CALCITE-2457] JUnit5 migration URL: https://github.com/apache/calcite/pull/1074 Don't merge used for tests. Using jupiter and vantage This is an automated message

[GitHub] Functor10 commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag…

Functor10 commented on issue #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag… URL: https://github.com/apache/calcite/pull/1025#issuecomment-468110881 @risdenk The bug still exists. May I need to open another issue in JIRA?

[GitHub] asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object

asereda-gs commented on issue #1071: [CALCITE-2877] Make GeodeSchema constructor public to pass client cache object URL: https://github.com/apache/calcite/pull/1071#issuecomment-468109254 Either this or #1022 should be merged

[GitHub] zhztheplayer commented on issue #881: [CALCITE-525] Exception-handling in built-in functions

zhztheplayer commented on issue #881: [CALCITE-525] Exception-handling in built-in functions URL: https://github.com/apache/calcite/pull/881#issuecomment-468079515 I'll close this for now, may reopen in future. This is an

[GitHub] zhztheplayer closed pull request #881: [CALCITE-525] Exception-handling in built-in functions

zhztheplayer closed pull request #881: [CALCITE-525] Exception-handling in built-in functions URL: https://github.com/apache/calcite/pull/881 This is an automated message from the Apache Git Service. To respond to the

[GitHub] zabetak closed pull request #709: [CALCITE-2288] Assertion type issue when reducing expression

zabetak closed pull request #709: [CALCITE-2288] Assertion type issue when reducing expression URL: https://github.com/apache/calcite/pull/709 This is an automated message from the Apache Git Service. To respond to the

[GitHub] zabetak commented on issue #709: [CALCITE-2288] Assertion type issue when reducing expression

zabetak commented on issue #709: [CALCITE-2288] Assertion type issue when reducing expression URL: https://github.com/apache/calcite/pull/709#issuecomment-468073553 As observed by @vlsi and @siddharthteotia the problem seems to be solved. I am closing this PR and the respective JIRA.

[GitHub] zabetak closed pull request #708: [CALCITE-2290] Fix type issue while flattening

zabetak closed pull request #708: [CALCITE-2290] Fix type issue while flattening URL: https://github.com/apache/calcite/pull/708 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] zabetak commented on issue #708: [CALCITE-2290] Fix type issue while flattening

zabetak commented on issue #708: [CALCITE-2290] Fix type issue while flattening URL: https://github.com/apache/calcite/pull/708#issuecomment-468072392 @vlsi and @siddharthteotia observed that the test no longer fails in master 1.19.0-SNAPSHOT. Since @laurentgo didn't follow up I am closing

[GitHub] vlsi commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative

vlsi commented on a change in pull request #1073: [CALCITE-2338] Make Simplification API more conservative URL: https://github.com/apache/calcite/pull/1073#discussion_r26091 ## File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java ## @@ -1652,7 +1658,7

[GitHub] vlsi removed a comment on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

vlsi removed a comment on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-468032131 LGTM This is an automated

[GitHub] kgyrtkirk opened a new pull request #1073: [CALCITE-2338] Make Simplification API more conservative

kgyrtkirk opened a new pull request #1073: [CALCITE-2338] Make Simplification API more conservative URL: https://github.com/apache/calcite/pull/1073 Deprecated simplifyOr/simplitfyAnd methods as alternate entry points may not get that much attention during development. Before this,

[GitHub] vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260954522 ## File path: core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260953414 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952927 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952365 ## File path:

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260952125 ## File path:

[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468036956 >"generate at most N permutation" part. Are you referring to some piece of code that I can

[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468035971 > @siddharthteotia , this PR adds extremely specific feature, and I don't see how the

[GitHub] julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

julianhyde commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260949061 ## File path:

[GitHub] vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

vlsi commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468033965 @siddharthteotia , this PR adds extremely specific feature, and I don't see how the behavior is

[GitHub] vlsi commented on a change in pull request #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

vlsi commented on a change in pull request #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#discussion_r260946766 ## File path:

[GitHub] vlsi commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

vlsi commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-468032131 LGTM This is an automated message

[GitHub] laurentgo merged pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner

laurentgo merged pull request #1058: [CALCITE-2827] Allow Convention.NONE planning with VolcanoPlanner URL: https://github.com/apache/calcite/pull/1058 This is an automated message from the Apache Git Service. To respond to

[GitHub] siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

siddharthteotia commented on issue #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds URL: https://github.com/apache/calcite/pull/1034#issuecomment-468028636 ping? cc @laurentgo , @vladimirdolzhenko

[GitHub] vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

vlsi commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260938059 ## File path: core/src/test/java/org/apache/calcite/rex/RexExecutorTest.java

[GitHub] risdenk closed pull request #825: Add space to working directory to catch tests that fail to support folders with spaces

risdenk closed pull request #825: Add space to working directory to catch tests that fail to support folders with spaces URL: https://github.com/apache/calcite/pull/825 This is an automated message from the Apache Git

[GitHub] risdenk commented on issue #825: Add space to working directory to catch tests that fail to support folders with spaces

risdenk commented on issue #825: Add space to working directory to catch tests that fail to support folders with spaces URL: https://github.com/apache/calcite/pull/825#issuecomment-468008399 Closing since appveyor has spaces in folder names as far as I know. Also no JIRA in the title for

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260919310 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260919177 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260918775 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

vlsi commented on a change in pull request #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#discussion_r260918529 ## File path: core/src/test/java/org/apache/calcite/test/ObjectArrayTableTest.java

[GitHub] risdenk commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta…

risdenk commented on issue #921: [CALCITE-2658] Add ExchangeRemoveConstantKeysRule that removes consta… URL: https://github.com/apache/calcite/pull/921#issuecomment-468006494 @chunweilei Squash commits? This is an automated

[GitHub] risdenk closed pull request #909: Avoid removing project in ProjectRemoveRule when row types are differ…

risdenk closed pull request #909: Avoid removing project in ProjectRemoveRule when row types are differ… URL: https://github.com/apache/calcite/pull/909 This is an automated message from the Apache Git Service. To respond

[GitHub] risdenk commented on issue #909: Avoid removing project in ProjectRemoveRule when row types are differ…

risdenk commented on issue #909: Avoid removing project in ProjectRemoveRule when row types are differ… URL: https://github.com/apache/calcite/pull/909#issuecomment-468006671 Closing since no JIRA in title and consensus is to not fix from 2 committers.

[GitHub] risdenk commented on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule

risdenk commented on issue #912: [CALCITE-2658] introducing WindowReduceExpressionsRule URL: https://github.com/apache/calcite/pull/912#issuecomment-468006412 @chunweilei multiple commits as part of this PR for two JIRAs?

[GitHub] risdenk commented on issue #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException

risdenk commented on issue #971: [CALCITE-1703] Functions on TIMESTAMP column throws ClassCastException URL: https://github.com/apache/calcite/pull/971#issuecomment-468005422 @vlsi - planning to merge still? This is an

[GitHub] risdenk commented on issue #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions

risdenk commented on issue #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions URL: https://github.com/apache/calcite/pull/997#issuecomment-468004277 Closing since JIRA closed This is an automated message

[GitHub] risdenk closed pull request #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions

risdenk closed pull request #997: [CALCITE-2780] Replace UnmodifiableArrayList with JDK Functions URL: https://github.com/apache/calcite/pull/997 This is an automated message from the Apache Git Service. To respond to the

[GitHub] risdenk closed pull request #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag…

risdenk closed pull request #1025: [CALCITE-2679] Fix a bug that `any_value` can't be used with other ag… URL: https://github.com/apache/calcite/pull/1025 This is an automated message from the Apache Git Service. To respond

[GitHub] risdenk commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

risdenk commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260897241 ## File path:

[GitHub] siddharthteotia commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER

siddharthteotia commented on issue #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#issuecomment-467987770 ping? cc @laurentgo , @vladimirdolzhenko I am not sure exactly who

[GitHub] zhztheplayer merged pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in…

zhztheplayer merged pull request #1060: [CALCITE-2787] Json aggregate calls with different null clause get in… URL: https://github.com/apache/calcite/pull/1060 This is an automated message from the Apache Git Service. To

[GitHub] yuqi1129 opened a new pull request #1072: [CALCITE-2879] Improve filter condition in Join

yuqi1129 opened a new pull request #1072: [CALCITE-2879] Improve filter condition in Join URL: https://github.com/apache/calcite/pull/1072 Close apache/calcite#1013 This is an automated message from the Apache Git Service.

  1   2   3   4   >