Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
ame result. I would be conservative, and memoize based on identity of the RelNodes, not just equality. It would be useful if you could come up with a test case in pure Calcite, then log a jira case. Julian > On Jan 25, 2023, at 12:56 AM, Moritz Mack wrote: > > Dear Calcite Devs, >

[jira] [Created] (CALCITE-5503) Memoize visited nodes in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack (Jira)
Moritz Mack created CALCITE-5503: Summary: Memoize visited nodes in CheapestPlanReplacer Key: CALCITE-5503 URL: https://issues.apache.org/jira/browse/CALCITE-5503 Project: Calcite Issue Type

Re: [SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-27 Thread Moritz Mack
I would be conservative, and memoize based on identity of the RelNodes, not just equality. It would be useful if you could come up with a test case in pure Calcite, then log a jira case. Julian > On Jan 25, 2023, at 12:56 AM, Moritz Mack wrote: > > Dear Calcite Devs, > > I’m currently

[SUPPORT] Semantics change when applying ConverterRule in CheapestPlanReplacer

2023-01-25 Thread Moritz Mack
Dear Calcite Devs, I’m currently looking into an issue in the SQL extension [1] of Apache Beam and was hoping to find some advice here. Using a bunch of Calcite ConverterRules [2], we convert a RelNode tree into a tree of BeamRelNodes which is then used to build a Beam DAG. Pretty standard I su