Question on PulledUpPredicates

2023-10-25 Thread Paul Jackson
eturn them from the perspective of the current RelNode? Paul Jackson

Re: Question on PulledUpPredicates

2023-10-25 Thread Paul Jackson
Please ignore this question. The method I needed was mq.getPulledUpPredicates. -Paul On Wednesday, October 25, 2023 at 03:35:07 PM EDT, Paul Jackson wrote: I'm currently working on CALCITE-6044. I have a problem that I thought would be solved by mq.getAllPredicates(rel) bu

Re: Removing FLOAT

2023-10-26 Thread Paul Jackson
Doesn't having two types help distinguish which type is in the source database for platforms that support both? A call to org.apache.calcite.sql.type.SqlTypeName#getNameForJdbcType would lose that distinction. I don't know offhand whether there are databases that require a CAST when converting

Would appreciate help with first PR

2023-11-01 Thread Paul Jackson
I just created https://github.com/apache/calcite/pull/3495 for  https://issues.apache.org/jira/browse/CALCITE-6044. It's my first PR. I'm getting what appears to be a code quality error or a test failure in  ServerTest.testTruncateTable(), which passes when I run it locally. Any tips for where to

PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Paul Jackson
This PR updates org.apache.calcite.rel.metadata areColumnsUnique, getUniqueKeys, and getPredicates methods to account for relations that produce at most a single row: Sort (due to limit), Aggregate (due to no group by), Values (due to having a single row), and Join (when joining with one of the

Re: PR 3495 (Make single-row rels unique) Review Request

2023-11-16 Thread Paul Jackson
rsday, November 16, 2023 at 01:46:35 PM EST, Julian Hyde wrote: These links are easier: * https://github.com/apache/calcite/pull/3495 * https://issues.apache.org/jira/browse/CALCITE-6044 > On Nov 16, 2023, at 7:51 AM, Paul Jackson > wrote: > > This PR updates org.apache.cal

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-08 Thread Paul Jackson
Is there anything else to do for this PR? * https://github.com/apache/calcite/pull/3495 * https://issues.apache.org/jira/browse/CALCITE-6044 Thanks, -Paul > On Nov 16, 2023, at 7:51 AM, Paul Jackson > wrote: > > This PR updates org.apache.calcite.rel.metadata areC

Re: PR 3495 (Make single-row rels unique) Review Request

2024-01-11 Thread Paul Jackson
Mihai Budiu wrote: > > CI failed, so perhaps you can look into that. > > Mihai > ____ > From: Paul Jackson > Sent: Monday, January 8, 2024 7:06 AM > To: dev@calcite.apache.org > Subject: Re: PR 3495 (Make single-row rels unique) Review Reque

[jira] [Created] (CALCITE-3101) PushDownJoinConditions is not always a valid transformation

2019-05-29 Thread Paul Jackson (JIRA)
Paul Jackson created CALCITE-3101: - Summary: PushDownJoinConditions is not always a valid transformation Key: CALCITE-3101 URL: https://issues.apache.org/jira/browse/CALCITE-3101 Project: Calcite

[jira] [Created] (CALCITE-2129) Aggregating function from subquery not projected properly

2018-01-10 Thread Paul Jackson (JIRA)
Paul Jackson created CALCITE-2129: - Summary: Aggregating function from subquery not projected properly Key: CALCITE-2129 URL: https://issues.apache.org/jira/browse/CALCITE-2129 Project: Calcite

[jira] [Created] (CALCITE-2130) Converting subquery to join is not always giving equivalent behavior

2018-01-10 Thread Paul Jackson (JIRA)
Paul Jackson created CALCITE-2130: - Summary: Converting subquery to join is not always giving equivalent behavior Key: CALCITE-2130 URL: https://issues.apache.org/jira/browse/CALCITE-2130 Project

[jira] [Created] (CALCITE-2131) Provide an option to NOT convert subquery to JOIN

2018-01-10 Thread Paul Jackson (JIRA)
Paul Jackson created CALCITE-2131: - Summary: Provide an option to NOT convert subquery to JOIN Key: CALCITE-2131 URL: https://issues.apache.org/jira/browse/CALCITE-2131 Project: Calcite

[jira] [Created] (CALCITE-2146) Errant CyclicMetadataException in multithreaded context

2018-01-22 Thread Paul Jackson (JIRA)
Paul Jackson created CALCITE-2146: - Summary: Errant CyclicMetadataException in multithreaded context Key: CALCITE-2146 URL: https://issues.apache.org/jira/browse/CALCITE-2146 Project: Calcite

[jira] [Created] (CALCITE-6044) Column uniqueness for single-row relations

2023-10-10 Thread Paul Jackson (Jira)
Paul Jackson created CALCITE-6044: - Summary: Column uniqueness for single-row relations Key: CALCITE-6044 URL: https://issues.apache.org/jira/browse/CALCITE-6044 Project: Calcite Issue Type

[jira] [Created] (CALCITE-6126) Return type check fails with OVER without AS

2023-11-20 Thread Paul Jackson (Jira)
Paul Jackson created CALCITE-6126: - Summary: Return type check fails with OVER without AS Key: CALCITE-6126 URL: https://issues.apache.org/jira/browse/CALCITE-6126 Project: Calcite Issue