Re: [CALCITE-4431] Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2021-01-24 Thread Vladimir Sitnikov
Thank you, Stamatis and Haisheng for the feedback. I will rebase the PR soon. Vladimir

Re: [CALCITE-4431] Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2020-12-09 Thread Haisheng Yuan
Makes sense. On 2020/12/09 22:44:35, Stamatis Zampetakis wrote: > Sounds reasonable and shares some goals with JEP358 [1] so why not. > > [1] https://openjdk.java.net/jeps/358 > > On Wed, Dec 9, 2020 at 8:26 AM Vladimir Sitnikov < > sitnikov.vladi...@gmail.com> wrote: > > > Hi, > > > > I

Re: [CALCITE-4431] Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2020-12-09 Thread Stamatis Zampetakis
Sounds reasonable and shares some goals with JEP358 [1] so why not. [1] https://openjdk.java.net/jeps/358 On Wed, Dec 9, 2020 at 8:26 AM Vladimir Sitnikov < sitnikov.vladi...@gmail.com> wrote: > Hi, > > I suggest we use requireNonNull(var, "var") pattern rather > than requireNonNull(var). > >

[jira] [Created] (CALCITE-4431) Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages

2020-12-08 Thread Vladimir Sitnikov (Jira)
Vladimir Sitnikov created CALCITE-4431: -- Summary: Use requireNonNull(var, "var") instead of requireNonNull(var) for better error messages Key: CALCITE-4431 URL: